hermes created branch test/va-host-hosted-report in dc/dc 2026-11-18 15:54:51 +00:00
hermes pushed to docs/embed-page at dc/docs.datacontroller.io 2026-11-18 15:51:20 +00:00
26ad4f2f65 docs(embed): the hosted page keeps its licence banner
hermes pushed to feat/embed-polish at dc/dc 2026-11-18 15:51:08 +00:00
979a960309 fix(embed): the licence banner is not suppressed for an embedded page
hermes pushed to docs/embed-page at dc/docs.datacontroller.io 2026-11-18 15:43:53 +00:00
59b1590435 docs(embed): one switch for the report context, va=1
hermes commented on pull request dc/dc#639 2026-11-18 15:34:31 +00:00
fix(embed): mark the chosen table, order the formula row, deliver into the running editor

Reviewed the delta since 380d060e (review 1377): one commit, 73c72155, adding a spec case that pins hosted=1 as the hosting marker. No source file changed, so the findings from that review stand…

hermes pushed to feat/embed-polish at dc/dc 2026-11-18 15:30:12 +00:00
73c72155e3 test(embed): pin that the report page is hosted by hosted=1, not by embed
hermes commented on pull request dc/dc#641 2026-11-18 15:21:01 +00:00
feat(mocks): read staged inputs and adapter tables through webout FETCH

Reviewed the delta since 5741b7ac (reviews 1372 and 1374): two commits - fda2a0de degrading every staged-path read instead of throwing, 94c3f032 dropping the @sasjs/lint override and rewriting…

hermes commented on pull request dc/dc#639 2026-11-18 15:20:44 +00:00
fix(embed): mark the chosen table, order the formula row, deliver into the running editor

Reviewed the delta since d74a585b (review 1373): one commit, 380d060e, retiring embed outright - the parser fallback, the in-place URL migration, the globals.embed carrier and…

hermes commented on pull request dc/dc#639 2026-11-18 15:14:11 +00:00
fix(embed): mark the chosen table, order the formula row, deliver into the running editor

embed is gone, and the six findings are in, at 380d060.

The retirement, as asked. Nothing reads embed any more: va=1 is what embed=va meant, `header=1

hermes pushed to feat/embed-polish at dc/dc 2026-11-18 15:14:03 +00:00
380d060e7d fix(embed): embed is retired, va=1 is what it meant, and six findings
hermes pushed to docs/embed-page at dc/docs.datacontroller.io 2026-11-18 15:08:12 +00:00
fc85982eca docs(embed): the report page is hosted with hosted=1
hermes commented on pull request dc/dc#641 2026-11-18 15:03:23 +00:00
feat(mocks): read staged inputs and adapter tables through webout FETCH

All nine addressed at 94c3f032, plus the failing Build-and-test-development is being watched (it is the Cypress job, not a test of this diff - see the last…

hermes pushed to feat/mock-fetch-inputs at dc/dc 2026-11-18 15:03:08 +00:00
94c3f032bf chore(deps): drop the lint override at the CLI 8 bump and refresh the pin note
fda2a0de84 fix(mocks): degrade an unreadable or absent input instead of throwing
Compare 2 commits »
hermes commented on pull request dc/dc#481 2026-11-18 15:02:42 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Re-review at d10cbb56. The delta since 215d1cbe is three commits merging #640 (fix(client): quote values that hold a quote character in the upload csv) plus its service test: spreadsheet-util.ts…

hermes commented on pull request dc/dc#641 2026-11-18 14:35:01 +00:00
feat(mocks): read staged inputs and adapter tables through webout FETCH

Supplement to review 1372, which landed at this head 5741b7ac while this review was being written: Gitea has no review edit, so the material that review does not carry goes in a second COMMENT.…

hermes commented on pull request dc/dc#639 2026-11-18 14:34:24 +00:00
fix(embed): mark the chosen table, order the formula row, deliver into the running editor

Reviewed the full diff at d74a585b against 215d1cbe: the branch was rewritten since the last review - 519a5ae7 still exists but is not an ancestor of the new head (the forge's compare of the two…

hermes commented on pull request dc/dc#641 2026-11-18 14:26:38 +00:00
feat(mocks): read staged inputs and adapter tables through webout FETCH

REVIEWED ON 2026-11-18 14:26 UTC

Reviewed the full base...head diff: mock services (dcMockUtils, getdata, loadfile, stagedata, makedata), the test harness and the new staged-inputs tests, plus…

hermes commented on pull request dc/dc#639 2026-11-18 14:19:46 +00:00
fix(embed): mark the chosen table, order the formula row, deliver into the running editor

Rebased onto release/7.23 (215d1cb) and the three findings are in, at d74a585 - the PR should be conflict-free now; the conflict was styles.scss, where #638's tree-label truncation and…

hermes pushed to feat/embed-polish at dc/dc 2026-11-18 14:19:37 +00:00
d74a585bb6 test(embed): pin the rule the early capture and the parser both implement
51231757db fix(embed): a prompt's columns follow its table, and the pages shrink
fef61c3df4 fix(embed): the early capture listens for the switch the designer now writes
10c2c1f1be fix(embed): the page is the Embed Designer, and eight review findings
ce0a224ed7 feat(embed): a Show header switch on the designer, off by default
Compare 10 commits »
hermes commented on pull request dc/dc#640 2026-11-18 14:12:00 +00:00
fix(client): quote values that hold a quote character in the upload csv

Still disagree on this one, at 29a30eba - and the premise is the part that needs settling, so here is the evidence rather than a restatement.…