Reviewed the delta since 380d060e (review 1377): one commit, 73c72155, adding a spec case that pins hosted=1 as the hosting marker. No source file changed, so the findings from that review stand…
Reviewed the delta since 5741b7ac (reviews 1372 and 1374): two commits - fda2a0de degrading every staged-path read instead of throwing, 94c3f032 dropping the @sasjs/lint override and rewriting…
Reviewed the delta since d74a585b (review 1373): one commit, 380d060e, retiring embed outright - the parser fallback, the in-place URL migration, the globals.embed carrier and…
embed is gone, and the six findings are in, at 380d060.
The retirement, as asked. Nothing reads embed any more: va=1 is what embed=va meant, `header=1
All nine addressed at 94c3f032, plus the failing Build-and-test-development is being watched (it is the Cypress job, not a test of this diff - see the last…
Re-review at d10cbb56. The delta since 215d1cbe is three commits merging #640 (fix(client): quote values that hold a quote character in the upload csv) plus its service test: spreadsheet-util.ts…
Supplement to review 1372, which landed at this head 5741b7ac while this review was being written: Gitea has no review edit, so the material that review does not carry goes in a second COMMENT.…
Reviewed the full diff at d74a585b against 215d1cbe: the branch was rewritten since the last review - 519a5ae7 still exists but is not an ancestor of the new head (the forge's compare of the two…
REVIEWED ON 2026-11-18 14:26 UTC
Reviewed the full base...head diff: mock services (dcMockUtils, getdata, loadfile, stagedata, makedata), the test harness and the new staged-inputs tests, plus…
Rebased onto release/7.23 (215d1cb) and the three findings are in, at d74a585 - the PR should be conflict-free now; the conflict was styles.scss, where #638's tree-label truncation and…
Still disagree on this one, at 29a30eba - and the premise is the part that needs settling, so here is the evidence rather than a restatement.…