hermes pushed to feat/mock-fetch-inputs at dc/dc 2026-11-18 17:10:01 +00:00
af3222c8f4 test(cypress): let acceptTermsIfPresented decide whether the card is showing
b0abb1c0ec fix(mocks): read every declared part, and report a read failure as itself
Compare 2 commits »
hermes commented on pull request dc/dc#639 2026-11-18 17:05:29 +00:00
fix(embed): mark the chosen table, order the formula row, deliver into the running editor

Fixed at b600719, and the finding was right about the substance: linkParamsFor wrote the definition and app, nothing else, so the copied link pasted into a web-content object attached no…

hermes pushed to docs/embed-page at dc/docs.datacontroller.io 2026-11-18 17:05:22 +00:00
67843de1ef docs(embed): the report link arrives with va=1
hermes pushed to feat/embed-polish at dc/dc 2026-11-18 17:05:13 +00:00
b6007195a0 fix(embed): the report link carries va=1, so pasting it into a report works
hermes commented on pull request dc/dc#641 2026-11-18 16:58:43 +00:00
feat(mocks): read staged inputs and adapter tables through webout FETCH

Re-review of the delta since 89e69607 (review 1383): one commit, 2bdc04a6, touching only client/cypress/support/commands.ts - the EULA card accepted before the licence tabs are reached. The three…

hermes pushed to feat/mock-fetch-inputs at dc/dc 2026-11-18 16:51:23 +00:00
2bdc04a6e1 test(cypress): accept the EULA before reaching for the licensing tabs
hermes commented on pull request dc/dc#641 2026-11-18 16:18:57 +00:00
feat(mocks): read staged inputs and adapter tables through webout FETCH

Reviewed the delta since 94c3f032 (review 1378) at head 89e69607: two commits - loadfile naming the file it could not read and printing unreadable instead of (-1 bytes), a sparse-part case for…

hermes commented on pull request dc/dc#639 2026-11-18 16:18:43 +00:00
fix(embed): mark the chosen table, order the formula row, deliver into the running editor

Reviewed the delta since 979a9603 (review 1380) at head d3e4ba2a: two commits - an e2e case for a hosted report taking its prompt values from the host, and the rename cleanup (va-host/host.js…

hermes commented on pull request dc/dc#639 2026-11-18 16:10:56 +00:00
fix(embed): mark the chosen table, order the formula row, deliver into the running editor

Everything folded in at d3e4ba2 - the separate PR (#642) is closed and its branch deleted, since the case belongs where the contract is.

The CI failure was mine, and it was the banner.…

hermes deleted branch test/va-host-hosted-report from dc/dc 2026-11-18 16:10:48 +00:00
hermes closed pull request dc/dc#642 2026-11-18 16:10:48 +00:00
test(embed): a hosted report takes its prompts from the host
hermes pushed to docs/embed-page at dc/docs.datacontroller.io 2026-11-18 16:10:41 +00:00
670a8a7b6b docs(va): say what a link carrying embed has to become
hermes pushed to feat/embed-polish at dc/dc 2026-11-18 16:10:32 +00:00
d3e4ba2a41 fix(embed): the hosted-report case, and the review that followed the rename
d2f71f4dc6 test(embed): a hosted report takes its prompts from the host
Compare 2 commits »
hermes commented on pull request dc/dc#641 2026-11-18 16:08:44 +00:00
feat(mocks): read staged inputs and adapter tables through webout FETCH

All three addressed at f93fe812, and the Cypress job has a candidate fix at 89e69607.

loadfile.js:70 - agreed, and the comment was wrong. The catch left csvName empty, so the abort reported…

hermes pushed to feat/mock-fetch-inputs at dc/dc 2026-11-18 16:08:33 +00:00
89e696070e test(cypress): wait for the login form or the tree, not two seconds
hermes commented on pull request dc/dc#642 2026-11-18 16:05:44 +00:00
test(embed): a hosted report takes its prompts from the host

Reviewed the diff: one Cypress case added to client/cypress/e2e/va-ddc-host.cy.ts. CI at this head is red, but not for this diff: Build / Build-and-ng-test fails at Angular Tests on…

hermes commented on pull request dc/dc#639 2026-11-18 16:05:26 +00:00
fix(embed): mark the chosen table, order the formula row, deliver into the running editor

Reviewed the delta since 73c72155 (review 1379): one commit, 979a9603, renaming the report page's hosting flag from hosted to va and no longer suppressing the licence banner for a report…

hermes pushed to feat/mock-fetch-inputs at dc/dc 2026-11-18 16:00:12 +00:00
f93fe81239 fix(mocks): report an unreadable upload by name, and pin the sparse parts scan
hermes created pull request dc/dc#642 2026-11-18 15:54:58 +00:00
test(embed): a hosted report takes its prompts from the host
hermes created branch test/va-host-hosted-report in dc/dc 2026-11-18 15:54:51 +00:00