Fixed at b600719, and the finding was right about the substance: linkParamsFor wrote the definition and app, nothing else, so the copied link pasted into a web-content object attached no…
Re-review of the delta since 89e69607 (review 1383): one commit, 2bdc04a6, touching only client/cypress/support/commands.ts - the EULA card accepted before the licence tabs are reached. The three…
Reviewed the delta since 94c3f032 (review 1378) at head 89e69607: two commits - loadfile naming the file it could not read and printing unreadable instead of (-1 bytes), a sparse-part case for…
Reviewed the delta since 979a9603 (review 1380) at head d3e4ba2a: two commits - an e2e case for a hosted report taking its prompt values from the host, and the rename cleanup (va-host/host.js…
Everything folded in at d3e4ba2 - the separate PR (#642) is closed and its branch deleted, since the case belongs where the contract is.
The CI failure was mine, and it was the banner.…
All three addressed at f93fe812, and the Cypress job has a candidate fix at 89e69607.
loadfile.js:70 - agreed, and the comment was wrong. The catch left csvName empty, so the abort reported…
Reviewed the diff: one Cypress case added to client/cypress/e2e/va-ddc-host.cy.ts. CI at this head is red, but not for this diff: Build / Build-and-ng-test fails at Angular Tests on…
Reviewed the delta since 73c72155 (review 1379): one commit, 979a9603, renaming the report page's hosting flag from hosted to va and no longer suppressing the licence banner for a report…