hermes

hermes commented on pull request dc/dc#337

2026-10-05 01:09:01 +00:00

feat(mocks): read the DC_MAX* options from MPE_CONFIG, and mock the DDL export

Added, in the second case of getcols.test.sas - you are right that this is the only place the SAS path can be pinned, and I had missed that the file already existed when I said the service had…

hermes pushed to feat/mock-config-and-ddl at dc/dc

2026-10-05 01:08:54 +00:00

93ef9228aa test(getcols): assert the TYPE vocabulary in the SAS suite

hermes commented on pull request dc/dc#337

2026-10-04 19:53:08 +00:00

feat(mocks): read the DC_MAX* options from MPE_CONFIG, and mock the DDL export

Re-review at bcad05e, superseding the review at dbc3044. The delta since the previous head is a single commit (the TYPE widening in getcols.sas); this pass focused on that, with the full…

hermes commented on pull request dc/dc#337

2026-10-04 19:08:53 +00:00

feat(mocks): read the DC_MAX* options from MPE_CONFIG, and mock the DDL export

Confirmed and fixed - length type $4; now precedes the set cols1.

The mechanism is exactly as you describe: %mp_getcols assigns type='C'/type='N' with no length statement, so…

hermes pushed to feat/mock-config-and-ddl at dc/dc

2026-10-04 19:08:53 +00:00

bcad05e032 fix(getcols): widen TYPE before assigning the client vocabulary

hermes commented on pull request dc/dc#337

2026-10-04 18:27:57 +00:00

feat(mocks): read the DC_MAX* options from MPE_CONFIG, and mock the DDL export

Re-review at dbc3044, superseding the reviews at a42c7fa, 05126ae and edac9a9 (the branch history was rewritten in between, so the current diff is the review surface). Checked the full base...head…

hermes commented on pull request dc/dc#337

2026-10-04 17:58:10 +00:00

feat(mocks): read the DC_MAX* options from MPE_CONFIG, and mock the DDL export

One follow-up from the first CI run on this head: the scan has to run before the job writes client/.npmrc. That step materialises the registry credential from the NPMRC secret into the…

hermes commented on pull request dc/dc#337

2026-10-04 17:54:55 +00:00

feat(mocks): read the DC_MAX* options from MPE_CONFIG, and mock the DDL export

Re-review at the new head (supersedes the reviews at edac9a9 and 05126ae; none of their findings are re-raised). Checked the full base...head diff as one unit: the MPE_CONFIG-driven limits in the…

hermes pushed to feat/mock-config-and-ddl at dc/dc

2026-10-04 17:47:36 +00:00

dbc3044a0f ci(hooks): scan for secrets in CI, and add the pre-commit framework config

hermes pushed to feat/mock-config-and-ddl at dc/dc

2026-10-04 17:41:34 +00:00

8e7ad91f2d ci(hooks): scan for secrets in CI, and add the pre-commit framework config

hermes commented on pull request dc/dc#337

2026-10-04 17:40:11 +00:00

feat(mocks): read the DC_MAX* options from MPE_CONFIG, and mock the DDL export

Both routes are in, and ignore-scripts stays.

.pre-commit-config.yaml - added at the repo root, mirroring sasjs/cli and sasjs/lint: the gitleaks hook pinned to rev: v8.30.1, with…

hermes pushed to feat/mock-config-and-ddl at dc/dc

2026-10-04 17:40:11 +00:00

a42c7fa716 ci(hooks): scan for secrets in CI, and add the pre-commit framework config

hermes commented on pull request dc/dc#338

2026-10-04 17:08:01 +00:00

fix(filters): source the picker variables from public/getcols when the table is not returned

Re-review at the new head bcb8fde. The delta since a20ce96: TYPE carried on the fallback list, the temporal exclusion dropped, and the cypress case extended to submit a character filter. Findings…

hermes commented on pull request dc/dc#338

2026-10-04 16:27:18 +00:00

fix(filters): source the picker variables from public/getcols when the table is not returned

All three addressed.

TYPE - confirmed, and it was the most consequential of the three. The fallback list does bypass mergeColsRules, so col.TYPE was never set and every column came…

hermes pushed to feat/filter-vars-fallback at dc/dc

2026-10-04 16:27:18 +00:00

bcb8fde986 fix(filters): carry TYPE on the fallback list, and drop the temporal exclusion

hermes commented on pull request dc/dc#338

2026-10-04 14:25:09 +00:00

fix(filters): source the picker variables from public/getcols when the table is not returned

Re-review at the new head a20ce96. The delta since 1385741 is the merged mock refactor (#339: sas/mocks/sasjs/services/dcMockUtils.js mpGetcols plus its adoption in editors/getdata.js, public/getco…

hermes commented on pull request dc/dc#338

2026-10-04 13:40:26 +00:00

fix(filters): source the picker variables from public/getcols when the table is not returned

Re-review at the new head 1385741: both findings from the previous review are addressed - %global at sas/sasjs/services/public/getcols.sas:59 replaces the open-code %local, and %mp_getcols at…

hermes created pull request dc/dc#339

2026-10-04 12:46:55 +00:00

refactor(mocks): a JS mpGetcols mirroring %mp_getcols.sas

hermes pushed to refactor/mock-mp-getcols at dc/dc

2026-10-04 12:46:55 +00:00

55fd16d53c refactor(mocks): a JS mpGetcols mirroring %mp_getcols.sas

hermes created branch refactor/mock-mp-getcols in dc/dc

2026-10-04 12:46:55 +00:00