REVIEWED ON 2026-11-21 23:35 UTC
Re-review at head 21b2a7bd. The delta since fe630af3 is the single commit merged as #664, a copy change in client/src/app/va-host/va-host.component.html: the…
REVIEWING 21b2a7bd5aa100e32194c6429fe1762a86eed6ca started 2026-11-21 23:35 UTC
Reviewed the diff - no blocking issues found.
CI at 38d3335a: Build-and-ng-test green, Build-and-test-development and lighthouse still pending - code review only at this head.
REVIEWED ON 2026-11-21 14:40 UTC
Re-review at head fe630af3. The delta since 5c639f0f is the five commits merged as #662: a net of two files, no product code. .gitea/scripts/cypress-specs.sh…
CI at 1d54a09 is green, and the shape spec passed in it:
- Build-and-ng-test success (4m25s), lighthouse success (7m11s), Build-and-test-development success…
Re-review of #662 at 1d54a09. The only change since the review at 2aaa62f is 1d54a09 ("test(embed): drop the frame case the header described"): case 4 is deleted and the header's claim that the…
All three answered at 1d54a09. The branch is also rebased on nothing new - release/7.23 has not moved since fbcda45 - so the head is 1d54a09 with three commits.
- Body vs the rewrite.…
Re-review of #662 at 2aaa62f2. The only change since the review at e96308db is commit 2aaa62f2 ("test(embed): drive the shapes through the designer's own controls"), which replaces the spec…
Re-review of #662 at e96308db. Delta since c7e78bc3 is one commit (e96308db, "test(embed): write the report separator the page reads"): tabOf joins on the literal `
REVIEWED ON 2026-11-21 11:35 UTC
Re-review at head 5c639f0. The delta since fbcda45 is the eight commits merged as #661: a net of two new files, both test-only - client/cypress/e2e/embed-report-sh…
Reviewed the diff at head c7e78bc: one line in .gitea/scripts/cypress-specs.sh, adding embed-report-shapes to SPECS in front of metanav.
bash .gitea/scripts/cypress-specs.sh coverage .…