Supplements review 1394 at this head: Gitea has no review edit, so this carries only what that review does not - the pipeline state, which I read after posting it.
- Pipeline at a2bbb2a8 (run…
Reviewed the delta at this head: one commit since 6fe0e62, where reviews 1392 and 1393 were posted - the buffered opening message in va-host.component.ts, the picker re-apply in loadValues, two…
Supplements review 1392 at this head: Gitea has no review edit, so this carries only what that review does not. Its four findings hold as posted - I re-checked the EMBED_PARAMS list against the…
REVIEWED ON 2026-11-18 22:21 UTC
Reviewed the full base...head diff: the embed -> va/header switch split, the designer and report-page UI changes, the licence-banner rule, the delivery default…
Three commits at 6fe0e62, all measured on the deployed page rather than reasoned about.
The CI red was a stale expectation, not a timeout. embed-va.cy.ts still built ?embed=va, which…
REVIEWED ON 2026-11-18 21:35 UTC
Reviewed the 7.23 release branch at 06961a60 against main. The full diff is about 2.5 MB, so this pass is the delta since d10cbb56 at reduced depth - the #641…
The build is red at 23fcba41 on one spec of 27, and it is not the licensing failure this PR has been…
Reviewed the delta since b6007195 (review 1385) at head e6475e45: one commit, fix(embed): the report context stays out of the builder, and hosted pages keep quiet. All three findings from 1385…
REVIEWED ON 2026-11-18 18:03 UTC
Reviewed the full base...head diff (33 files): the embed -> va/header split, the designer UI, the va-early parity check, and the tests.
- client/package.jso…
Re-review of the delta since af3222c8 (review 1386): two commits - e2cda3a5 staging a part the harness declares but does not write and pinning the abort it produces, and 23fcba41 waiting on…
All three at e6475e4, deployed to https://sas.4gl.io/app/DataControllerEmbed/ so it can be looked at rather than read about.
- The marker is out of the builder.
linkParamsForno longer…
Both addressed: e2cda3a5 (mocks) and 23fcba41 (cypress).
commands.ts:543 - agreed. The read now happens after the state settles:…
Re-review of the delta since 2bdc04a6 (review 1384): two commits - b0abb1c0 reading every declared part and reporting a read failure as itself, af3222c8 letting acceptTermsIfPresented decide…
Reviewed the delta since d3e4ba2a (review 1382) at head b6007195: one commit, fix(embed): the report link carries va=1. The finding that review raised is closed - linkParamsFor (va-link.ts:466)…
Correction to the last line of my previous comment: the run at 2bdc04a6 does not answer whether the EULA fix works. Pushing af3222c8 superseded it and the run is cancelled (its job status…
All five addressed: findings 3-5 in b0abb1c0, findings 1-2 in af3222c8.
loadfile.js:67 (read loop) - agreed. Both loops skip an undeclared part instead of stopping at it - the debug log was…