hermes commented on pull request dc/dc#644 2026-11-19 20:37:32 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

Supplements review 1402 at this head: Gitea reviews cannot be edited, so this carries what that body does not have, plus the two findings from the review at ccf8929f that the delta left open.…

hermes commented on pull request dc/dc#644 2026-11-19 20:35:45 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

REVIEWED ON 2026-11-19 20:35 UTC

Reviewed the full base...head diff (prompt source/target column split, per-tab frame remount, style changes) at head 7eae9d6.

  • client/src/app/va-host/va-host.com…
hermes pushed to feat/embed-target-column at dc/dc 2026-11-19 20:17:03 +00:00
7eae9d60b1 fix(client): give the report its own page inset back
448dbe52dc fix(embed): open a report tab in its own frame
Compare 2 commits »
hermes commented on pull request dc/dc#644 2026-11-19 18:27:36 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

Reviewed the embed prompt-mapping change at ccf8929 (code review only: Build-and-test-development and lighthouse were still running at this head).

  • client/src/app/va-host/va-host.component.ts:930…
hermes created pull request dc/dc#644 2026-11-19 18:16:56 +00:00
fix(embed): give a prompt reading another table a target column picker
hermes pushed to feat/embed-target-column at dc/dc 2026-11-19 18:13:44 +00:00
ccf8929fdb fix(client): space the editor actions evenly and inset the page
b82e822879 fix(embed): map a prompt's source column to its LOAD-table column
Compare 2 commits »
hermes created branch feat/embed-target-column in dc/dc 2026-11-19 18:13:44 +00:00
hermes commented on pull request dc/dc#481 2026-11-19 14:03:07 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Reviewed the delta since 26b57207, the head reviewed earlier: two commits of #643 plus its follow-up and the merge, 8 files - the "Embed Designer" heading and its Cypress rename, the embed URL…

hermes commented on pull request dc/dc#643 2026-11-19 13:30:47 +00:00
feat(embed): title the builder Embed Designer, and show the embed URL beside the VA filter controls

Re-reviewed at b73eba66, superseding the review at 769864d0. The only change since then is one commit: the copyableEmbedUrl justification rewritten around how a filter key resolves, the VA…

hermes commented on pull request dc/dc#643 2026-11-19 13:24:04 +00:00
feat(embed): title the builder Embed Designer, and show the embed URL beside the VA filter controls

All three taken, pushed as b73eba66 (3 files, +40/-9). Verdict per finding:

1. agreed - the reason was wrong, the cut stays. mpe_filtermaster.sas:94 resolves filter_rk against…

hermes pushed to feat/embed-designer-url at dc/dc 2026-11-19 13:23:40 +00:00
b73eba668e fix(embed): justify the filter-key cut by how the key resolves, and clear the copy timer
hermes commented on pull request dc/dc#643 2026-11-19 11:36:50 +00:00
feat(embed): title the builder Embed Designer, and show the embed URL beside the VA filter controls

Rerun of the failed job is in, and it is green: POST /actions/runs/4147/rerun-failed-jobs (job 7053) finished at 11:34…

hermes commented on pull request dc/dc#643 2026-11-19 11:09:52 +00:00
feat(embed): title the builder Embed Designer, and show the embed URL beside the VA filter controls

CI at 769864d0: Build-and-ng-test success (client coverage posted above), lighthouse success (every route at or above the 0.95 accessibility gate), Build-and-test-development failure on…

hermes commented on pull request dc/dc#643 2026-11-19 10:50:31 +00:00
feat(embed): title the builder Embed Designer, and show the embed URL beside the VA filter controls

Reviewed the diff at 769864d0 (2 commits, 8 files). Code review only: Build-and-test-development is still pending at this head (Build-and-ng-test and lighthouse are green), and the Cypress…

hermes created pull request dc/dc#643 2026-11-19 10:36:26 +00:00
feat(embed): title the builder Embed Designer, and show the embed URL beside the VA filter controls
hermes pushed to feat/embed-designer-url at dc/dc 2026-11-19 10:36:19 +00:00
769864d096 feat(embed): show the embed URL beside the VA filter controls
630c34839d feat(embed): call the report builder the Embed Designer
Compare 2 commits »
hermes created branch feat/embed-designer-url in dc/dc 2026-11-19 10:36:19 +00:00
hermes commented on pull request dc/dc#481 2026-11-18 23:56:14 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Supplement to review 1396 at this head, which does not carry these findings and cannot be edited in place on this forge. Review surface: the delta since 06961a60 (reviewed 21:35 UTC) - 19 commits,…

hermes commented on pull request dc/dc#481 2026-11-18 23:52:00 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

REVIEWED ON 2026-11-18 23:52 UTC

Reviewed the full base...head diff at reduced depth (the diff is very large: SAS macros/services, the mock-server test suite, the client, va-host, and the Gitea…

hermes commented on pull request dc/dc#639 2026-11-18 23:14:24 +00:00
fix(embed): mark the chosen table, order the formula row, deliver into the running editor

Green at a2bbb2a: 190 of 190 Cypress tests across 27 specs, 19m15s, and the other two jobs succeeded. Build-and-ng-test 3m11s, Lighthouse 7m13s.

What the red run at 6fe0e62 actually…