Supplements review 1402 at this head: Gitea reviews cannot be edited, so this carries what that body does not have, plus the two findings from the review at ccf8929f that the delta left open.…
REVIEWED ON 2026-11-19 20:35 UTC
Reviewed the full base...head diff (prompt source/target column split, per-tab frame remount, style changes) at head 7eae9d6.
- client/src/app/va-host/va-host.com…
Reviewed the embed prompt-mapping change at ccf8929 (code review only: Build-and-test-development and lighthouse were still running at this head).
- client/src/app/va-host/va-host.component.ts:930…
Reviewed the delta since 26b57207, the head reviewed earlier: two commits of #643 plus its follow-up and the merge, 8 files - the "Embed Designer" heading and its Cypress rename, the embed URL…
Re-reviewed at b73eba66, superseding the review at 769864d0. The only change since then is one commit: the copyableEmbedUrl justification rewritten around how a filter key resolves, the VA…
All three taken, pushed as b73eba66 (3 files, +40/-9). Verdict per finding:
1. agreed - the reason was wrong, the cut stays. mpe_filtermaster.sas:94 resolves filter_rk against…
Rerun of the failed job is in, and it is green: POST /actions/runs/4147/rerun-failed-jobs (job 7053) finished at 11:34…
CI at 769864d0: Build-and-ng-test success (client coverage posted above), lighthouse success (every route at or above the 0.95 accessibility gate), Build-and-test-development failure on…
Reviewed the diff at 769864d0 (2 commits, 8 files). Code review only: Build-and-test-development is still pending at this head (Build-and-ng-test and lighthouse are green), and the Cypress…
Supplement to review 1396 at this head, which does not carry these findings and cannot be edited in place on this forge. Review surface: the delta since 06961a60 (reviewed 21:35 UTC) - 19 commits,…
REVIEWED ON 2026-11-18 23:52 UTC
Reviewed the full base...head diff at reduced depth (the diff is very large: SAS macros/services, the mock-server test suite, the client, va-host, and the Gitea…
Green at a2bbb2a: 190 of 190 Cypress tests across 27 specs, 19m15s, and the other two jobs succeeded. Build-and-ng-test 3m11s, Lighthouse 7m13s.
What the red run at 6fe0e62 actually…