REVIEWED ON 2026-11-20 04:37 UTC
Reviewed the full diff - va-host designer and report chrome, embed-flag parsing, shell header wiring and styles. No security, injection or secret-handling issues;…
The frame-route finding is addressed at 694d1df2; the pipeline note is the CI state, covered below.
frameShowsAnotherRoutenow treats an empty actual route as unknown rather than as another…
REVIEWED ON 2026-11-20 03:32 UTC
Reviewed the full base..head diff of dc/dc#644 (Angular client: embed flag parsing, va-host designer and report, styles, specs) - the flag-parsing refactor, the…
Both findings are addressed at 754a8ccc, one push for the round.
backToEditorstatesva=1&header=1, so the editor comes back with its header, back button and sub-nav rather than inheriting…
REVIEWED ON 2026-11-20 03:07 UTC
Reviewed the full base...head diff: header-flag plumbing between the shell and the report page, prompt source/target mapping, per-tab frame remounting, report…
Correction to my previous reply on the header finding, at f45f6db5.
Scoping the handler to the report page was wrong: leaving a report with the switch off left globals.headerVisible false, and…
All three findings are addressed at b3aef5cc, one push for the round.
onPromptTypeChange, the branch reading another table: the source column's own type now decides. If the metadata says it…
REVIEWED ON 2026-11-20 02:31 UTC
Reviewed the full diff: va-host prompt source/target mapping, report title and description, header-flag sync between page URL and shell, embedded sizing,…
All three findings are addressed at db3ec4e2, one push for the round.
- Palette: the light palette is the unscoped
.va-reportdefault and the dark block still overrides it, so a report painted…
REVIEWED ON 2026-11-20 01:56 UTC
Reviewed the full base...head diff of dc/dc#644 (editable report title/description, source/target column mapping per prompt, report-level header switch, per-tab…
Both findings are addressed at e0fb7789, one push for the round.
restore(): only the switch answers to the URL now. A stored title and description are restored whateverheaderthe URL…
REVIEWED ON 2026-11-20 01:31 UTC
Reviewed the full base..head diff for dc/dc#644 (Angular embed designer: separate prompt source/target columns, per-report header switch and title, themed report…
On the report height - I have since measured it, so the earlier "could not measure" stands corrected.
Fixture at /opt/data/profiles/dc/workspace/dc644-height-fixture (not committed): the shell…