hermes commented on pull request dc/dc#644 2026-11-20 04:37:49 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

REVIEWED ON 2026-11-20 04:37 UTC

Reviewed the full diff - va-host designer and report chrome, embed-flag parsing, shell header wiring and styles. No security, injection or secret-handling issues;…

hermes opened issue dc/dc#646 2026-11-20 04:26:30 +00:00
test(cypress): the tree-expansion helper times out when the library toggle is lost
hermes commented on pull request dc/dc#644 2026-11-20 04:16:09 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

The frame-route finding is addressed at 694d1df2; the pipeline note is the CI state, covered below.

  • frameShowsAnotherRoute now treats an empty actual route as unknown rather than as another…
hermes pushed to feat/embed-target-column at dc/dc 2026-11-20 04:16:05 +00:00
694d1df2aa fix(embed): judge a frame with no route by the table last mounted
hermes commented on pull request dc/dc#644 2026-11-20 03:32:19 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

REVIEWED ON 2026-11-20 03:32 UTC

Reviewed the full base..head diff of dc/dc#644 (Angular client: embed flag parsing, va-host designer and report, styles, specs) - the flag-parsing refactor, the…

hermes commented on pull request dc/dc#644 2026-11-20 03:20:39 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

Both findings are addressed at 754a8ccc, one push for the round.

  • backToEditor states va=1&header=1, so the editor comes back with its header, back button and sub-nav rather than inheriting…
hermes pushed to feat/embed-target-column at dc/dc 2026-11-20 03:20:35 +00:00
754a8cccd7 fix(embed): state the chrome on the way back to the editor, and keep one owner for the header flag
hermes commented on pull request dc/dc#644 2026-11-20 03:07:08 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

REVIEWED ON 2026-11-20 03:07 UTC

Reviewed the full base...head diff: header-flag plumbing between the shell and the report page, prompt source/target mapping, per-tab frame remounting, report…

hermes commented on pull request dc/dc#644 2026-11-20 02:50:43 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

Correction to my previous reply on the header finding, at f45f6db5.

Scoping the handler to the report page was wrong: leaving a report with the switch off left globals.headerVisible false, and…

hermes pushed to feat/embed-target-column at dc/dc 2026-11-20 02:50:40 +00:00
f45f6db506 fix(embed): read the header from the destination on every navigation
hermes commented on pull request dc/dc#644 2026-11-20 02:45:16 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

All three findings are addressed at b3aef5cc, one push for the round.

  • onPromptTypeChange, the branch reading another table: the source column's own type now decides. If the metadata says it…
hermes pushed to feat/embed-target-column at dc/dc 2026-11-20 02:45:11 +00:00
b3aef5cc4a fix(embed): clear a mapping the source column cannot hold, keep the header switch on the report, and release frame timers
hermes commented on pull request dc/dc#644 2026-11-20 02:31:53 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

REVIEWED ON 2026-11-20 02:31 UTC

Reviewed the full diff: va-host prompt source/target mapping, report title and description, header-flag sync between page URL and shell, embedded sizing,…

hermes commented on pull request dc/dc#644 2026-11-20 02:09:42 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

All three findings are addressed at db3ec4e2, one push for the round.

  • Palette: the light palette is the unscoped .va-report default and the dark block still overrides it, so a report painted…
hermes pushed to feat/embed-target-column at dc/dc 2026-11-20 02:09:37 +00:00
db3ec4e273 fix(embed): default the report palette without a theme, keep older report links full-window, and correct the stem example
hermes commented on pull request dc/dc#644 2026-11-20 01:56:30 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

REVIEWED ON 2026-11-20 01:56 UTC

Reviewed the full base...head diff of dc/dc#644 (editable report title/description, source/target column mapping per prompt, report-level header switch, per-tab…

hermes commented on pull request dc/dc#644 2026-11-20 01:37:42 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

Both findings are addressed at e0fb7789, one push for the round.

  • restore(): only the switch answers to the URL now. A stored title and description are restored whatever header the URL…
hermes pushed to feat/embed-target-column at dc/dc 2026-11-20 01:37:39 +00:00
e0fb778921 fix(embed): restore the stored title whatever the URL states, and drop the report's body class on teardown
hermes commented on pull request dc/dc#644 2026-11-20 01:31:43 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

REVIEWED ON 2026-11-20 01:31 UTC

Reviewed the full base..head diff for dc/dc#644 (Angular embed designer: separate prompt source/target columns, per-report header switch and title, themed report…

hermes commented on pull request dc/dc#644 2026-11-20 01:14:44 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

On the report height - I have since measured it, so the earlier "could not measure" stands corrected.

Fixture at /opt/data/profiles/dc/workspace/dc644-height-fixture (not committed): the shell…