hermes commented on pull request dc/dc#644 2026-11-20 01:09:38 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

All four findings are addressed at aa558954, one push for the round.

  • Designer head: the title field now sits inside an <h2 class="designer-title">, so the page keeps a heading element, and…
hermes pushed to feat/embed-target-column at dc/dc 2026-11-20 01:09:33 +00:00
aa558954ac fix(embed): keep a heading, derive only equal stems, and clear a column of the wrong type
hermes commented on pull request dc/dc#481 2026-11-20 01:07:43 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

REVIEWED ON 2026-11-20 01:07 UTC

Reviewed the full base...head diff (392 files, ~2.6MB) at reduced depth, concentrated on the CI workflows and scripts, the new va-host component's security…

hermes commented on pull request dc/dc#644 2026-11-20 00:55:09 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

REVIEWED ON 2026-11-20 00:55 UTC

Reviewed the full diff at 6be86f3 (Angular client, cypress spec, styles): prompt source/target mapping, the report title and description, per-tab frame mounting,…

hermes commented on pull request dc/dc#645 2026-11-20 00:40:56 +00:00
feat(licensing): return to the page registration started from

REVIEWED ON 2026-11-20 00:40 UTC

Reviewed the full base...head diff: the registration return-URL utility and its spec, the licence-banner click hook, the licensing component redirect, and the…

hermes commented on pull request dc/dc#644 2026-11-20 00:39:09 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

All three findings are addressed at 6be86f3d, one push for the round.

  • va-host.component.ts - the query-param subscription now compares the emission with the parameters it last read and, when…
hermes pushed to feat/embed-target-column at dc/dc 2026-11-20 00:39:05 +00:00
6be86f3d84 fix(embed): keep the author's place on a header toggle, and read a legacy target as a target
hermes commented on pull request dc/dc#645 2026-11-20 00:18:47 +00:00
feat(licensing): return to the page registration started from

The Cypress case failed its first CI run: it wrote the raw URL while the reader parses {url, at}, so the install was sent home. Fixed at d3876127 - the case writes the stored object and sets it…

hermes pushed to feat/registration-return-url at dc/dc 2026-11-20 00:18:44 +00:00
d38761278a test(licensing): store the remembered page in the shape the reader parses
hermes commented on pull request dc/dc#644 2026-11-20 00:15:37 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

REVIEWED ON 2026-11-20 00:15 UTC

Reviewed the full base...head diff: prompt source/target column mapping, per-tab frame remounting, report title/description/header, dark theme work, and the…

hermes commented on pull request dc/dc#645 2026-11-19 23:56:16 +00:00
feat(licensing): return to the page registration started from

Reviewed the delta 36d42cde -> 3dcb8cfd (segment match for the licensing route, age bounded at both ends) and the full base...head diff at this head. The two findings from the review at 36d42cde…

hermes pushed to feat/embed-target-column at dc/dc 2026-11-19 23:55:03 +00:00
eac1924abe feat(embed): derive a prompt's target column rather than leaving it empty
hermes commented on pull request dc/dc#645 2026-11-19 23:47:32 +00:00
feat(licensing): return to the page registration started from

Both findings are addressed at 3dcb8cf, one push for the round.

  • registration-return-url.ts:36 - the guard now compares the route segment: the path is rejected only when it is exactly…
hermes pushed to feat/registration-return-url at dc/dc 2026-11-19 23:47:30 +00:00
3dcb8cfd33 fix(licensing): match the licensing route by segment and bound the remembered page's age
hermes commented on pull request dc/dc#644 2026-11-19 23:42:43 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

Reviewed the delta cc80e4d4...09c2fbfc at head 09c2fbfc (two commits: the header flag stated once on the page URL, frame re-apply timers kept and cleared, the frame route check tolerating the…

hermes commented on pull request dc/dc#645 2026-11-19 23:41:02 +00:00
feat(licensing): return to the page registration started from

REVIEWED ON 2026-11-19 23:41 UTC

Reviewed the full base...head diff: the registration return-URL utility, its unit spec, the licence-banner click hook, the licensing component redirect, and the…

hermes pushed to feat/embed-target-column at dc/dc 2026-11-19 23:39:55 +00:00
09c2fbfceb test(embed): make the header-switch case actually exercise the route params
hermes pushed to feat/embed-target-column at dc/dc 2026-11-19 23:36:07 +00:00
0978f9a87e fix(embed): answer the review, and stop reloading the frame on a prompt change
hermes commented on pull request dc/dc#644 2026-11-19 23:28:43 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

Reviewed the delta abc5935d...cc80e4d4 at head cc80e4d4 (one commit: the header switch writes its answer to the page URL, and headerVisible becomes a getter over globals). CI at this head:…

hermes commented on pull request dc/dc#645 2026-11-19 23:27:23 +00:00
feat(licensing): return to the page registration started from

Both findings are addressed at 36d42cd, one push for the round.

  • licensing.component.spec.ts - the spec now takes the activation state as a parameter, and…