hermes commented on pull request dc/dc#481 2026-11-20 09:34:40 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

REVIEWED ON 2026-11-20 09:34 UTC

Reviewed the full base...head diff: 392 files, so hardening and the licence/embed paths were read in full and the remainder skimmed - a reduced-depth review of…

hermes commented on pull request dc/dc#481 2026-11-20 09:11:44 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

REVIEWED ON 2026-11-20 09:11 UTC

Reviewed the delta since the previous review at 3f0dcc2 - the feat(embed) merge into the release branch and its follow-up fix/test commits - against the full…

hermes commented on pull request dc/dc#644 2026-11-20 08:09:14 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

Pipeline is green at 4c1711b5 on the first attempt this time: Build-and-ng-test, lighthouse and the full Cypress suite all succeeded.

hermes commented on pull request dc/dc#644 2026-11-20 08:01:43 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

REVIEWED ON 2026-11-20 08:01 UTC

Reviewed the full base...head diff: prompt source/target mapping and derived targets, per-tab frame reload, report title/description, the report header switch and…

hermes commented on pull request dc/dc#644 2026-11-20 07:41:09 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

Both findings are addressed at 4c1711b5, one push for the round.

  • The switch's label now carries for="va-report-header", so clicking the text toggles it and the checkbox has a programmatic…
hermes pushed to feat/embed-target-column at dc/dc 2026-11-20 07:41:04 +00:00
4c1711b5a9 fix(embed): name the designer heading and tie the report switch to its label
hermes commented on pull request dc/dc#644 2026-11-20 07:39:01 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

Pipeline is green at f19a101d on all three checks - Build-and-ng-test, lighthouse and the full Cypress suite - after a re-run: the first attempt hit the tree-expansion timeout again (full-table…

hermes commented on pull request dc/dc#644 2026-11-20 06:53:33 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

REVIEWED ON 2026-11-20 06:53 UTC

Reviewed the full base...head diff: prompt source/target mapping and derived targets, per-tab frame reload, report title/description, the report header switch and…

hermes commented on pull request dc/dc#644 2026-11-20 06:41:53 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

Both findings are addressed at f19a101d, one push for the round.

  • A reset's deferred address now goes through applyFrameUrlAfterReset, which applies it only while frameUrl is still the null…
hermes pushed to feat/embed-target-column at dc/dc 2026-11-20 06:41:49 +00:00
f19a101d1d fix(embed): let the newest mount win, and record why va stays per-load
hermes commented on pull request dc/dc#644 2026-11-20 06:38:47 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

Pipeline is green at efcdcbc8 on all three checks (Build-and-ng-test, lighthouse, Build-and-test-development) after a re-run of the Cypress job; that job's first attempt hit the tree-expansio…

hermes commented on pull request dc/dc#644 2026-11-20 06:28:48 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

REVIEWED ON 2026-11-20 06:28 UTC

Reviewed the full base...head diff: app shell header/route handling, va-host component and templates, the link/flag helpers, shared URL-flag parsing, styles, and…

hermes commented on pull request dc/dc#644 2026-11-20 05:45:17 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

All three findings are addressed at efcdcbc8, one push for the round.

  • derivedTarget collects the candidates whose stem matches and derives only when exactly one does, so a field spelled two…
hermes pushed to feat/embed-target-column at dc/dc 2026-11-20 05:45:12 +00:00
efcdcbc893 fix(embed): leave an ambiguous stem alone, clear a mapping the table cannot vouch for, and keep the editor's gutter
hermes commented on pull request dc/dc#644 2026-11-20 05:28:04 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

REVIEWED ON 2026-11-20 05:28 UTC

Reviewed the full diff - embed-flag parsing (parse-embed-flags/parse-url-flag), the shell's header wiring on NavigationEnd, the va-host prompt mapping and report…

hermes commented on pull request dc/dc#644 2026-11-20 05:12:32 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

Both findings are addressed at 6a724370, one push for the round.

  • backToEditor states header=1 only when the page is not itself framed (window.self === window.top); a framed page keeps the…
hermes pushed to feat/embed-target-column at dc/dc 2026-11-20 05:12:25 +00:00
6a724370d8 fix(embed): keep a hosted object chromeless, and scope the report page's inset
hermes commented on pull request dc/dc#644 2026-11-20 05:05:11 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

REVIEWED ON 2026-11-20 05:05 UTC

Reviewed the full diff - embed-flag parsing and the shell's header wiring, the va-host designer and report chrome, the frame mount path and the styles; both…

hermes commented on pull request dc/dc#644 2026-11-20 04:45:35 +00:00
feat(embed): prompt mapping, per-tab frames, a titled report, and dark mode

Both findings are addressed at 01a9c52d, one push for the round.

  • onPromptColumnChange drops selected, values and valuesLoaded with the new source column, so the next preview re-reads…
hermes pushed to feat/embed-target-column at dc/dc 2026-11-20 04:45:30 +00:00
01a9c52d44 fix(embed): drop the reader's choice with the mapping, and read a link's source column like a stored design's