Reviewed the diff at head b5361928 - the column cache in va-host.component.ts and the specs that pin it. The branch is a single commit rewritten on top of 3258311 (release/7.23), so the previous…
All three answered at b5361928.
1. A failing fresh read left the superseded list in place - the entry is now dropped before the request, not after it answers:…
Reviewed the diff at head 10a5e9bc - the column cache in va-host.component.ts and the specs that pin it. The branch is a single commit rewritten on top of 3258311 (release/7.23), and the previous…
Answered at 10a5e9bc.
The finding: a fresh read that answered with no columns neither kept nor dropped, so the list the page kept for that table earlier survived it - a design re-read while the…
Reviewed the diff at head db3fe361 - the column cache in va-host.component.ts and the cases that pin it. The branch is a single commit rewritten on top of bc00f58 (compare a909981d...db3fe361…
Answered at db3fe361.
Finding: columnCache.set kept an empty answer, so the comment's promise held only for a read that threw, and one answer without a cols table held the picker empty for…
Reviewed the diff at head a909981d - the column cache in va-host.component.ts and the cases that pin it. The branch is a single commit rewritten on top of bc00f58 (compare 2f9d406e...a909981d…
All four answered at a909981d.
1. restore() still read through the cache (va-host.component.ts:1697) - it passes fresh now, so a stored design is read against the estate as it is, not…
Reviewed the diff at head 2f9d406e - the column cache in va-host.component.ts and the cases that pin it. The head moved from 85b05234 (one commit, branch rewritten), which closed both earlier…
Answered both findings at 2f9d406e.
1. The kept list defeated the repairing reads - columnsIn() now takes fresh, and the two reads whose purpose is to see a table as it is now pass it:…
Re-review at head bc00f58c. Since the review at 32583118 the only change is one commit (bc00f58c, "fix: spec bug") touching one line: sas/sasjs/services/editors/getdata.sas:566 now appends…
Reviewed the diff at head 85b05234 - the column cache in va-host.component.ts and the spec cases that pin it. Build / Build-and-ng-test is still pending at this sha, so this is a code review only,…