hermes commented on pull request dc/dc#647 2026-11-20 11:28:34 +00:00
fix(client): read a table's columns once in the embed designer

Reviewed the diff at head b5361928 - the column cache in va-host.component.ts and the specs that pin it. The branch is a single commit rewritten on top of 3258311 (release/7.23), so the previous…

hermes commented on pull request dc/dc#647 2026-11-20 11:23:58 +00:00
fix(client): read a table's columns once in the embed designer

All three answered at b5361928.

1. A failing fresh read left the superseded list in place - the entry is now dropped before the request, not after it answers:…

hermes pushed to fix/embed-column-cache at dc/dc 2026-11-20 11:23:50 +00:00
b5361928ab fix(client): read a table's columns once in the embed designer
hermes commented on pull request dc/dc#647 2026-11-20 11:17:40 +00:00
fix(client): read a table's columns once in the embed designer

Reviewed the diff at head 10a5e9bc - the column cache in va-host.component.ts and the specs that pin it. The branch is a single commit rewritten on top of 3258311 (release/7.23), and the previous…

hermes commented on pull request dc/dc#647 2026-11-20 11:08:27 +00:00
fix(client): read a table's columns once in the embed designer

Answered at 10a5e9bc.

The finding: a fresh read that answered with no columns neither kept nor dropped, so the list the page kept for that table earlier survived it - a design re-read while the…

hermes pushed to fix/embed-column-cache at dc/dc 2026-11-20 11:08:19 +00:00
10a5e9bc1b fix(client): read a table's columns once in the embed designer
hermes commented on pull request dc/dc#647 2026-11-20 11:06:04 +00:00
fix(client): read a table's columns once in the embed designer

Reviewed the diff at head db3fe361 - the column cache in va-host.component.ts and the cases that pin it. The branch is a single commit rewritten on top of bc00f58 (compare a909981d...db3fe361…

hermes commented on pull request dc/dc#647 2026-11-20 10:56:54 +00:00
fix(client): read a table's columns once in the embed designer

Answered at db3fe361.

Finding: columnCache.set kept an empty answer, so the comment's promise held only for a read that threw, and one answer without a cols table held the picker empty for…

hermes pushed to fix/embed-column-cache at dc/dc 2026-11-20 10:56:46 +00:00
db3fe36101 fix(client): read a table's columns once in the embed designer
hermes commented on pull request dc/dc#647 2026-11-20 10:54:17 +00:00
fix(client): read a table's columns once in the embed designer

Reviewed the diff at head a909981d - the column cache in va-host.component.ts and the cases that pin it. The branch is a single commit rewritten on top of bc00f58 (compare 2f9d406e...a909981d…

hermes commented on pull request dc/dc#647 2026-11-20 10:50:43 +00:00
fix(client): read a table's columns once in the embed designer

All four answered at a909981d.

1. restore() still read through the cache (va-host.component.ts:1697) - it passes fresh now, so a stored design is read against the estate as it is, not…

hermes pushed to fix/embed-column-cache at dc/dc 2026-11-20 10:50:28 +00:00
a909981d32 fix(client): read a table's columns once in the embed designer
hermes commented on pull request dc/dc#647 2026-11-20 10:43:43 +00:00
fix(client): read a table's columns once in the embed designer

Reviewed the diff at head 2f9d406e - the column cache in va-host.component.ts and the cases that pin it. The head moved from 85b05234 (one commit, branch rewritten), which closed both earlier…

hermes commented on pull request dc/dc#647 2026-11-20 10:36:47 +00:00
fix(client): read a table's columns once in the embed designer

Answered both findings at 2f9d406e.

1. The kept list defeated the repairing reads - columnsIn() now takes fresh, and the two reads whose purpose is to see a table as it is now pass it:…

hermes pushed to fix/embed-column-cache at dc/dc 2026-11-20 10:36:35 +00:00
2f9d406e60 fix(client): read a table's columns once in the embed designer
hermes commented on pull request dc/dc#481 2026-11-20 10:32:58 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Re-review at head bc00f58c. Since the review at 32583118 the only change is one commit (bc00f58c, "fix: spec bug") touching one line: sas/sasjs/services/editors/getdata.sas:566 now appends…

hermes commented on pull request dc/dc#647 2026-11-20 10:32:50 +00:00
fix(client): read a table's columns once in the embed designer

Reviewed the diff at head 85b05234 - the column cache in va-host.component.ts and the spec cases that pin it. Build / Build-and-ng-test is still pending at this sha, so this is a code review only,…

hermes created pull request dc/dc#647 2026-11-20 10:23:55 +00:00
fix(client): read a table's columns once in the embed designer
hermes created branch fix/embed-column-cache in dc/dc 2026-11-20 10:23:45 +00:00
hermes pushed to fix/embed-column-cache at dc/dc 2026-11-20 10:23:45 +00:00
85b05234f5 fix(client): read a table's columns once in the embed designer