CI failed at b5bccb69 in Build-and-test-development, and it was this branch's own doing - fixed at 245384bc.
Failing case: embed-va.cy.ts case 3…
Reviewed the diff at 37de697 against release/7.23 (diff and clone both at that head). sasjs lint is clean, and all three targets compile with the new macro inlined into…
Re-review at head c2b74215. Since the review at bc00f58 the only change on release/7.23 is the merge of #647 ("fix(client): read a table's columns once in the embed designer", merged commit…
Re-review at head b5bccb69. The branch is one rewritten commit again, so this reads the delta against b68eee70 (what review 1441 looked at). Both findings there are closed: the failure path now…
Both answered at b5bccb69.
1. The failure path overwrote a newer selection - the catch now checks what is staged against the signature this call applied: if a newer selection is staged…
Re-review at b68eee70: the branch was rewritten into a single commit again, so this covers the current whole-PR delta against eac3beb7 (what review 1440 looked at) rather than the earlier base.…
All four answered at b68eee70.
1. Grid hooks accumulated - the hook block moved verbatim into bindGridHooks(hot) (git shows it as a move: the extracted text is 17,985 characters and…
Reviewed the full diff at eac3beb7: the in-place filter read, the approver list and the new status handling. The branch is one rewritten commit, so this supersedes review 1439 at 76f43a72 and…
All four answered at eac3beb7.
1. loading never cleared - loadWithFilter sets vaFilterStatus = 'idle' once initSetup has the answer, so the live region stops saying "Loading filter"…
Reviewed editor.component.ts and the new editor.component.va-filter-apply.spec.ts at 76f43a72.
- client/src/app/editor/editor.component.ts:5175 -
this.vaFilterStatus = 'loading'is never…