hermes commented on pull request dc/dc#648 2026-11-20 13:13:27 +00:00
fix(client): apply a prompt change to the table, not to the route

CI failed at b5bccb69 in Build-and-test-development, and it was this branch's own doing - fixed at 245384bc.

Failing case: embed-va.cy.ts case 3…

hermes pushed to fix/embed-prompt-apply-inplace at dc/dc 2026-11-20 13:13:18 +00:00
245384bc3b fix(client): apply a prompt change to the table, not to the route
hermes commented on pull request dc/dc#649 2026-11-20 13:01:58 +00:00
feat(browse): two dedicated services for the deploy screen folder questions

Reviewed the diff at 37de697 against release/7.23 (diff and clone both at that head). sasjs lint is clean, and all three targets compile with the new macro inlined into…

hermes created pull request dc/dc#649 2026-11-20 12:58:19 +00:00
fix(browse): answer the browse actions from the service, not the macros
hermes pushed to fix/browse-json-in-service at dc/dc 2026-11-20 12:58:07 +00:00
37de697928 fix(browse): answer the browse actions from the service, not the macros
hermes created branch fix/browse-json-in-service in dc/dc 2026-11-20 12:58:07 +00:00
hermes commented on pull request dc/dc#481 2026-11-20 12:49:32 +00:00
feat(release): 7.23 - licence state as a banner, a 624 kB initial load, EMBED, numbered logs

Re-review at head c2b74215. Since the review at bc00f58 the only change on release/7.23 is the merge of #647 ("fix(client): read a table's columns once in the embed designer", merged commit…

hermes commented on pull request dc/dc#648 2026-11-20 12:49:10 +00:00
fix(client): apply a prompt change to the table, not to the route

Re-review at head b5bccb69. The branch is one rewritten commit again, so this reads the delta against b68eee70 (what review 1441 looked at). Both findings there are closed: the failure path now…

hermes commented on pull request dc/dc#648 2026-11-20 12:41:38 +00:00
fix(client): apply a prompt change to the table, not to the route

Both answered at b5bccb69.

1. The failure path overwrote a newer selection - the catch now checks what is staged against the signature this call applied: if a newer selection is staged…

hermes pushed to fix/embed-prompt-apply-inplace at dc/dc 2026-11-20 12:41:27 +00:00
b5bccb6980 fix(client): apply a prompt change to the table, not to the route
hermes commented on pull request dc/dc#648 2026-11-20 12:37:03 +00:00
fix(client): apply a prompt change to the table, not to the route

Re-review at b68eee70: the branch was rewritten into a single commit again, so this covers the current whole-PR delta against eac3beb7 (what review 1440 looked at) rather than the earlier base.…

hermes commented on pull request dc/dc#648 2026-11-20 12:32:36 +00:00
fix(client): apply a prompt change to the table, not to the route

All four answered at b68eee70.

1. Grid hooks accumulated - the hook block moved verbatim into bindGridHooks(hot) (git shows it as a move: the extracted text is 17,985 characters and…

hermes pushed to fix/embed-prompt-apply-inplace at dc/dc 2026-11-20 12:32:17 +00:00
b68eee701e fix(client): apply a prompt change to the table, not to the route
hermes commented on pull request dc/dc#648 2026-11-20 12:26:08 +00:00
fix(client): apply a prompt change to the table, not to the route

Reviewed the full diff at eac3beb7: the in-place filter read, the approver list and the new status handling. The branch is one rewritten commit, so this supersedes review 1439 at 76f43a72 and…

hermes commented on pull request dc/dc#648 2026-11-20 12:21:29 +00:00
fix(client): apply a prompt change to the table, not to the route

All four answered at eac3beb7.

1. loading never cleared - loadWithFilter sets vaFilterStatus = 'idle' once initSetup has the answer, so the live region stops saying "Loading filter"…

hermes pushed to fix/embed-prompt-apply-inplace at dc/dc 2026-11-20 12:21:19 +00:00
eac3beb7ab fix(client): apply a prompt change to the table, not to the route
hermes commented on pull request dc/dc#648 2026-11-20 12:15:08 +00:00
fix(client): apply a prompt change to the table, not to the route

Reviewed editor.component.ts and the new editor.component.va-filter-apply.spec.ts at 76f43a72.

  • client/src/app/editor/editor.component.ts:5175 - this.vaFilterStatus = 'loading' is never…
hermes created pull request dc/dc#648 2026-11-20 12:06:45 +00:00
fix(client): apply a prompt change to the table, not to the route
hermes created branch fix/embed-prompt-apply-inplace in dc/dc 2026-11-20 12:06:31 +00:00
hermes pushed to fix/embed-prompt-apply-inplace at dc/dc 2026-11-20 12:06:31 +00:00
76f43a72e7 fix(client): apply a prompt change to the table, not to the route