dc/dc
dc/dc
3
1
Fork 0
Code Issues 15 Pull Requests 1 Actions Packages Projects Releases 35 Wiki Activity

fix: adjust the col numbers in extracted data #76

Merged
allan merged 5 commits from fix-complex-xl-upload into main 2024-02-12 09:58:42 +00:00
Conversation 0 Commits 5 Files Changed 11 +239 -67
sabir commented 2024-02-09 13:38:30 +00:00
Collaborator
Copy Link
No description provided.
sabir added 1 commit 2024-02-09 13:38:30 +00:00
fix: adjust the col numbers in extracted data
Some checks failed
Build / Build-and-ng-test (pull_request) Failing after 18s
Details
cff5989559
allan added 1 commit 2024-02-09 19:02:30 +00:00
feat: extra table metadata for #75
Some checks failed
Build / Build-and-ng-test (pull_request) Failing after 17s
Details
837821fd01
sabir added 1 commit 2024-02-12 06:31:09 +00:00
feat: show dsnote on hover title
Some checks failed
Build / Build-and-ng-test (pull_request) Failing after 18s
Details
6565834ad4
sabir added 1 commit 2024-02-12 07:51:16 +00:00
chore: lint fix
All checks were successful
Build / Build-and-ng-test (pull_request) Successful in 1m5s
Details
5a48f2e6e3
mihajlo reviewed 2024-02-12 09:34:12 +00:00
mihajlo requested changes 2024-02-12 09:35:50 +00:00
client/src/app/xlmap/xlmap.component.ts Outdated
@ -402,3 +402,1 @@
for (let j = 0; j < keys.length; j++) {
const key = keys[j]
const val = row[key]
for (let j = range.s.c, x = 0; j <= range.e.c; j++, x++) {
mihajlo commented 2024-02-12 09:35:42 +00:00
Owner
Copy Link

Can you leave a comment explaining range.s.c and what does the iteration aims to achieve?

Can you leave a comment explaining range.s.c and what does the iteration aims to achieve?
allan marked this conversation as resolved
sabir added 1 commit 2024-02-12 09:54:05 +00:00
chore: add comment
All checks were successful
Build / Build-and-ng-test (pull_request) Successful in 1m4s
Details
6a0fe287dd
allan merged commit f13e909478 into main 2024-02-12 09:58:42 +00:00
allan deleted branch fix-complex-xl-upload 2024-02-12 09:58:42 +00:00
mihajlo approved these changes 2024-02-12 10:15:13 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
mihajlo
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: dc/dc#76
No description provided.
Delete Branch "fix-complex-xl-upload"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?