dc/dc
6
1
Fork 0
Code Issues 20 Pull Requests 1 Actions Packages Projects Releases 69 Wiki Activity

Added support for European numeric formats #16

Merged
allan merged 6 commits from issue-1 into development 2023-08-23 14:46:37 +00:00
Conversation 4 Commits 6 Files Changed 8 +411 -349
mihajlo commented 2023-07-28 18:10:08 +00:00
Owner
Copy Link

App will first try to capture the browser locale and if found, that locale will be used in handsontable, otherwise Handsontable default (en-US) will be used.

App will first try to capture the browser locale and if found, that locale will be used in handsontable, otherwise Handsontable default (en-US) will be used.
mihajlo added 2 commits 2023-07-28 18:10:08 +00:00
feat: support for European numeric formats e48e47bc63
style: lint
All checks were successful
Build / Build-and-ng-test (pull_request) Successful in 7m39s
Details
5bb55e6484
allan was assigned by mihajlo 2023-07-28 18:10:16 +00:00
mihajlo added 1 commit 2023-07-28 18:10:26 +00:00
Merge branch 'development' into issue-1
All checks were successful
Build / Build-and-ng-test (pull_request) Successful in 7m40s
Details
7c98ad8c5b
allan reviewed 2023-07-28 19:07:50 +00:00
client/src/app/shared/dc-validator/utils/applyNumericFormats.ts Outdated
@@ -0,0 +2,4 @@
import * as languages from 'numbro/dist/languages.min'
/**
* Applying the numeric formats based on the browser locale/language
* @param rules rules to be updated
allan commented 2023-07-28 19:07:49 +00:00
Owner
Copy Link

can we provide more information on what these rules are?

can we provide more information on what these rules are?
mihajlo marked this conversation as resolved
allan reviewed 2023-07-28 19:08:11 +00:00
client/src/app/shared/dc-validator/utils/applyNumericFormats.ts Outdated
@@ -0,0 +1,22 @@
import { DcValidation } from '../models/dc-validation.model'
import * as languages from 'numbro/dist/languages.min'
/**
* Applying the numeric formats based on the browser locale/language
allan commented 2023-07-28 19:08:11 +00:00
Owner
Copy Link

can we have a sentence to explain why this is important?

can we have a sentence to explain why this is important?
mihajlo marked this conversation as resolved
allan commented 2023-07-29 11:49:44 +00:00
Owner
Copy Link

"It will first try to capture the browser locale and if found, it will be used in handsontable, otherwise Handsontable default (en-US) will be used." -> this information should ideally be in the code docs (comments) somewhere.

Also, please define "it"

"It will first try to capture the browser locale and if found, it will be used in handsontable, otherwise Handsontable default (en-US) will be used." -> this information should ideally be in the code docs (comments) somewhere. Also, please define "it"
mihajlo added 2 commits 2023-07-31 08:12:48 +00:00
chore: addressing comments 908d2761f2
chore(git): Merge branch 'issue-1' of ssh://git.datacontroller.io:29419/dc/dc into issue-1
All checks were successful
Build / Build-and-ng-test (pull_request) Successful in 7m52s
Details
52d4b3eefc
allan added 1 commit 2023-08-23 14:46:01 +00:00
Merge branch 'development' into issue-1
All checks were successful
Build / Build-and-ng-test (pull_request) Successful in 25s
Details
0a7d23c763
allan approved these changes 2023-08-23 14:46:17 +00:00
allan merged commit 8c2ee441fc into development 2023-08-23 14:46:37 +00:00
allan deleted branch issue-1 2023-08-23 14:46:37 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
allan
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
allan dcbot DylanLeong henrik mihajlo sabir sead trevor yury
No Assignees allan
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dc/dc#16
Delete Branch "issue-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?