dc/dc
dc/dc
3
1
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases 35 Wiki Activity

XLSX Performance Improvements (multi load) #118

Merged
mihajlo merged 8 commits from multi-load-performance into main 2024-07-26 11:34:21 +00:00
Conversation 0 Commits 8 Files Changed 42 +2081 -1415
mihajlo commented 2024-07-03 16:01:57 +00:00
Owner
Copy Link

Addressed Issues

  • While data is parsing from the file put spinners on sidebar items sheets
  • Download log should get log (if debug on) not the request
  • Extraction was taking extra row - could not reproduce
  • Show filesize when we attach the file
  • When filesize is greater then 2MB or so, parse sheet by sheet - not needed at the moment because we use Web Worker to parse
  • request() function which wraps the SASjsAdapter.request() function, should return log for the executed request
  • When you open review data on the sidebar, table should be full height
  • Tables dropdown abowe sidebar tree, indentation is wrong on the selected item
  • Fix all places of usage of the request() function after adding the 'LOG" property
## Addressed Issues - While data is parsing from the file put spinners on sidebar items sheets - Download log should get log (if debug on) not the request - Extraction was taking extra row - could not reproduce - Show filesize when we attach the file - When filesize is greater then 2MB or so, parse sheet by sheet - not needed at the moment because we use Web Worker to parse - request() function which wraps the SASjsAdapter.request() function, should return log for the executed request - When you open review data on the sidebar, table should be full height - Tables dropdown abowe sidebar tree, indentation is wrong on the selected item - Fix all places of usage of the request() function after adding the 'LOG" property
mihajlo added 3 commits 2024-07-03 16:01:57 +00:00
style: lint
All checks were successful
Build / Build-and-ng-test (pull_request) Successful in 3m58s
Details
857b94f44f
mihajlo added 1 commit 2024-07-05 13:45:17 +00:00
mihajlo added 1 commit 2024-07-05 13:46:22 +00:00
style: lint
All checks were successful
Build / Build-and-ng-test (pull_request) Successful in 3m54s
Details
ddc22e5200
mihajlo added 1 commit 2024-07-05 13:46:49 +00:00
Merge branch 'main' into multi-load-performance
All checks were successful
Build / Build-and-ng-test (pull_request) Successful in 3m58s
Details
74e9979c67
mihajlo changed title from WIP: XLSX Performance Improvements (multi load) to XLSX Performance Improvements (multi load) 2024-07-05 13:46:57 +00:00
mihajlo added 2 commits 2024-07-08 08:15:45 +00:00
mihajlo merged commit 403d08c86a into main 2024-07-26 11:34:20 +00:00
mihajlo deleted branch multi-load-performance 2024-07-26 11:34:21 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: dc/dc#118
No description provided.
Delete Branch "multi-load-performance"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?