Files
dc/client
dc d67a0e5d5f
Build / Build-and-ng-test (pull_request) Successful in 4m41s
Lighthouse Checks / lighthouse (pull_request) Successful in 18m19s
Build / Build-and-test-development (pull_request) Successful in 27m47s
fix(deploy): await nothing, and encode the values in the makedata URL
Addresses both findings from the review of #408.

runAutoDeploy was declared async after the service-pack step went, but calls
createDatabase() and returns without awaiting anything. createDatabase() starts
the request and reports through the component's own status flags rather than a
returned promise, so there is nothing to await - drop the async rather than
pretend to a contract the callee does not offer.

runMakedataInNewWindow interpolated the context name, admin group and DC path
straight into the query string. An ampersand in any of them started a new
parameter and a space arrived truncated; a DC path containing a slash was only
working because nothing decoded the query. Those three values are now
percent-encoded at the build site, so the server reads back what the user chose.

Tests: the new-window case now asserts the encoded forms, and a second case
pins the values that need encoding (context with an ampersand and spaces, admin
group with a space and a plus, DC path with a slash and a space). The deploy
case no longer awaits a synchronous handler.

Executed 24 of 24 SUCCESS (automatic + sasjs-configurator + deploy components).
2026-10-30 16:14:28 +00:00
..
2023-07-13 13:44:05 +02:00
2023-07-13 13:44:05 +02:00
2026-05-25 13:29:27 +02:00
2023-07-13 13:44:05 +02:00
2023-07-13 13:44:05 +02:00
2023-07-13 13:44:05 +02:00
2023-07-13 13:44:05 +02:00
2023-07-13 13:44:05 +02:00
2023-07-13 13:44:05 +02:00
2023-07-13 13:44:05 +02:00
2024-05-02 13:08:06 +02:00