feat: Complex Excel Uploads #71

Merged
allan merged 48 commits from issue69 into main 2024-01-24 13:48:07 +00:00
Owner
No description provided.
allan added 1 commit 2023-12-27 16:05:30 +00:00
Build / Build-and-ng-test (pull_request) Successful in 47s Details
271543a446
feat: model changes for #69
allan added 1 commit 2024-01-01 12:23:11 +00:00
Build / Build-and-ng-test (pull_request) Failing after 14s Details
2d4d068413
fix: increasing length of mpe_excel_map cols to
allan added 1 commit 2024-01-01 13:54:11 +00:00
Build / Build-and-ng-test (pull_request) Failing after 13s Details
6ae31de1dd
chore: adding sample data for basel KM1 template
allan added 1 commit 2024-01-01 14:10:53 +00:00
Build / Build-and-ng-test (pull_request) Failing after 13s Details
cc4535245c
chore: adding xlmaps in startupservice response, #69
allan added 1 commit 2024-01-01 14:50:07 +00:00
Build / Build-and-ng-test (pull_request) Failing after 13s Details
56264ecc69
feat: new getxlmaps service to return rules for a particular xlmap_id
allan added 1 commit 2024-01-01 16:07:51 +00:00
Build / Build-and-ng-test (pull_request) Failing after 13s Details
2702bb3c84
feat: adding ismap attribute to getdata response (and fixing test)
allan added 1 commit 2024-01-01 16:53:57 +00:00
Build / Build-and-ng-test (pull_request) Failing after 13s Details
a485c3b787
feat: validating the excel map after stage (adding load-ref)
allan added 1 commit 2024-01-03 12:12:44 +00:00
Build / Build-and-ng-test (pull_request) Failing after 13s Details
3e009f3037
chore: adding migration for new tables
allan added 1 commit 2024-01-11 14:44:17 +00:00
Build / Build-and-ng-test (pull_request) Failing after 14s Details
e747e6e4e7
chore: additional xlmaps to cover LASTDOWN and BLANKROW scenarios
allan added 1 commit 2024-01-11 18:11:26 +00:00
Build / Build-and-ng-test (pull_request) Failing after 13s Details
c86fba9dc7
feat: adding ability to define the target table for excel maps
allan added 1 commit 2024-01-11 18:28:55 +00:00
Build / Build-and-ng-test (pull_request) Failing after 12s Details
23708c9aae
chore: fix xlmap validation logic
allan added 1 commit 2024-01-11 18:48:19 +00:00
Build / Build-and-ng-test (pull_request) Failing after 13s Details
8d12d9e51e
chore: fixing validations
allan added 1 commit 2024-01-12 13:09:42 +00:00
Build / Build-and-ng-test (pull_request) Failing after 13s Details
e40ebdff05
Merge branch 'main' into issue69
allan added 14 commits 2024-01-16 09:16:45 +00:00
sabir added 1 commit 2024-01-16 09:28:01 +00:00
Build / Build-and-ng-test (pull_request) Failing after 13s Details
f0f9d85558
chore: quick fix
sabir added 1 commit 2024-01-16 10:26:15 +00:00
Build / Build-and-ng-test (pull_request) Failing after 13s Details
d75e10aef5
chore: quick fix
allan added 1 commit 2024-01-17 11:23:13 +00:00
Build / Build-and-ng-test (pull_request) Failing after 12s Details
1c3d498da6
chore: wording of rules page
sabir added 1 commit 2024-01-17 17:34:01 +00:00
Build / Build-and-ng-test (pull_request) Failing after 12s Details
d6ecd12cea
chore: added tab view in xlmap component
sabir added 1 commit 2024-01-17 17:38:46 +00:00
Build / Build-and-ng-test (pull_request) Failing after 13s Details
12b15df78c
chore: move to data tab after extracting data
sabir added 1 commit 2024-01-18 13:39:42 +00:00
Build / Build-and-ng-test (pull_request) Failing after 13s Details
c144fd8087
chore: fixed hanging state after getting error in upload and submit
allan added 1 commit 2024-01-18 15:43:53 +00:00
Build / Build-and-ng-test (pull_request) Failing after 13s Details
51b043b6d2
chore: postedit hook example updates
allan added 1 commit 2024-01-18 16:31:15 +00:00
Build / Build-and-ng-test (pull_request) Failing after 13s Details
01915a2db9
fix: renaming TABLE macvar to LOAD_REF in postdata.sas
also adding a sample post approve hook for xlmap dataloads
sabir added 1 commit 2024-01-18 17:19:21 +00:00
allan added 1 commit 2024-01-18 17:39:21 +00:00
Build / Build-and-ng-test (pull_request) Failing after 13s Details
fd94945466
fix: providing info on mapids to FE
allan added 1 commit 2024-01-19 10:52:43 +00:00
Build / Build-and-ng-test (pull_request) Failing after 12s Details
2d6e747db9
fix: reverting xlmap in getdata change
allan added 1 commit 2024-01-19 11:12:36 +00:00
Build / Build-and-ng-test (pull_request) Failing after 13s Details
9550ae4d11
fix: removing tables from EDIT menu that are in xlmaps
sabir added 1 commit 2024-01-19 13:49:06 +00:00
Build / Build-and-ng-test (pull_request) Failing after 14s Details
731b96dccc
chore: modifired xlmaps array in global variables
sabir added 1 commit 2024-01-19 16:04:06 +00:00
Build / Build-and-ng-test (pull_request) Failing after 13s Details
482c7455f5
chore: fix the logic for goback button in stage component
allan added 1 commit 2024-01-22 10:30:26 +00:00
Build / Build-and-ng-test (pull_request) Failing after 13s Details
802c99adf9
chore: fix .npmrc
mihajlo reviewed 2024-01-23 11:50:23 +00:00
@ -0,0 +370,4 @@
this.xlmapRules.forEach((rule) => {
let sheetName = rule.XLMAP_SHEET
if (sheetName.startsWith('/')) {
Owner

Can you add some comments?

Can you add some comments?
sabir marked this conversation as resolved
mihajlo reviewed 2024-01-23 11:52:05 +00:00
@ -0,0 +409,4 @@
const key = keys[j]
const val = row[key]
extractedData.push({
Owner

Can you add some comments? (eg. why we add +1 on index)

Can you add some comments? (eg. why we add +1 on index)
sabir marked this conversation as resolved
mihajlo reviewed 2024-01-23 11:53:51 +00:00
@ -0,0 +431,4 @@
public getCellAddress(rule: string, arrayOfObjects: any[]) {
if (rule.startsWith('ABSOLUTE ')) {
rule = rule.replace('ABSOLUTE ', '')
Owner

Can you add some comments? (eg. why do we remove it from rule string)

Can you add some comments? (eg. why do we remove it from rule string)
sabir marked this conversation as resolved
mihajlo reviewed 2024-01-23 11:55:41 +00:00
@ -0,0 +502,4 @@
}
}
const temp = XLSX.utils.decode_cell(cellAddress)
Owner

Can you add some comments? (eg. what's happening with encoding/decoding cells)

Can you add some comments? (eg. what's happening with encoding/decoding cells)
sabir marked this conversation as resolved
mihajlo reviewed 2024-01-23 11:56:05 +00:00
@ -0,0 +515,4 @@
return rule
}
public getFinishingCell(
Owner

Can you add some comments? (above function)

Can you add some comments? (above function)
sabir marked this conversation as resolved
allan added 1 commit 2024-01-23 12:10:22 +00:00
Build / Build-and-ng-test (pull_request) Failing after 1m9s Details
df065562d1
chore: bumping core
mihajlo reviewed 2024-01-23 12:33:51 +00:00
@ -0,0 +368,4 @@
public extractData(wb: XLSX.WorkBook) {
const extractedData: XLUploadEntry[] = []
this.xlmapRules.forEach((rule) => {
Owner

Can we make search functions to be in separate files inside a xlmap-route/utils or so, and add some tests for them?

Can we make search functions to be in separate files inside a xlmap-route/utils or so, and add some tests for them?
sabir marked this conversation as resolved
allan added 1 commit 2024-01-23 16:54:49 +00:00
Build / Build-and-ng-test (pull_request) Failing after 17s Details
93702c63dc
fix: removing XLMAP_TARGETLIBDS from mpe_xlmaps_rules table
sabir added 1 commit 2024-01-24 09:10:35 +00:00
Build / Build-and-ng-test (pull_request) Failing after 16s Details
233eca39ef
chore: move utility functions to separate file
sabir added 1 commit 2024-01-24 09:30:48 +00:00
Build / Build-and-ng-test (pull_request) Failing after 17s Details
8afee29e02
chore: limit submitting rows based on liscence
sabir added 1 commit 2024-01-24 10:30:31 +00:00
Build / Build-and-ng-test (pull_request) Failing after 23s Details
4653097225
chore: move utils to separate file
sabir added 1 commit 2024-01-24 12:05:27 +00:00
Build / Build-and-ng-test (pull_request) Failing after 17s Details
2a852496e9
chore: add specs
allan merged commit cf19381060 into main 2024-01-24 13:48:07 +00:00
allan deleted branch issue69 2024-01-24 13:48:07 +00:00
allan referenced this issue from a commit 2024-01-24 13:48:09 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: dc/dc#71
No description provided.