dc/dc
dc/dc
2
1
Fork 0
Code Issues 7 Pull Requests 1 Actions Packages Projects Releases 32 Wiki Activity

Dark Mode #102

Merged
allan merged 22 commits from issue98 into main 2024-05-31 09:21:07 +00:00
Conversation 0 Commits 22 Files Changed 72 +2192 -1451
mihajlo commented 2024-05-08 14:51:30 +00:00
Owner
Copy Link

Closes #98 #101

DC Dark Mode Places to fix

  • SAS Requests Modal

  • System

  • Scrollbar not dark in main scroll

  • Filtering modal

  • Metadata modal in edit view has close button jumping up

  • HOT context menu white

  • HOT when editing cell white

  • Editor table

    • Cancel edit button
    • Submit modal white

  • Edit Record Modal

    • Some fields are white
    • Cacnel Confirm buttons spacing

  • Viewboxes

    • Modal
      • Currently open hover is white
      • search columns input white
      • columns reorder white
      • [] close button bad position
    • Boxes
      • hot is white
      • background is white

  • Usernav Groups and Users

  • DC Tree Selected item is white

  • View library page

  • View table

  • View web query url

  • Stage

    • HOT white

  • Approve details

    • HOT white
    • Approval details table white
    • Changed rows numbe white

  • History

    • White table
    • Details modal white

  • Submitted

    • White table

  • Abort modals are white

  • HOT has too bright border lines

Dark Mode Feedback

  • Always persist current theme
  • Stage screen base table link is hardly visible
  • Edit table button (i) is hard to see
  • Mock sas9 services and check it's pages
Closes #98 #101 ## DC Dark Mode Places to fix - [x] SAS Requests Modal - [x] System - [x] Scrollbar not dark in main scroll - [x] Filtering modal - [x] Metadata modal in edit view has close button jumping up - [x] HOT context menu white - [x] HOT when editing cell white - Editor table - [x] Cancel edit button - [x] Submit modal white - Edit Record Modal - [x] Some fields are white - [x] Cacnel Confirm buttons spacing - Viewboxes - Modal - [x] Currently open hover is white - [x] search columns input white - [x] columns reorder white - [] close button bad position - Boxes - [x] hot is white - [x] background is white - [x] Usernav Groups and Users - [x] DC Tree Selected item is white - [x] View library page - [x] View table - [x] View web query url - Stage - [x] HOT white - Approve details - [x] HOT white - [x] Approval details table white - [x] Changed rows numbe white - History - [x] White table - [x] Details modal white - Submitted - [x] White table - [x] Abort modals are white - [x] HOT has too bright border lines ## Dark Mode Feedback - [x] Always persist current theme - [x] Stage screen base table link is hardly visible - [x] Edit table button (i) is hard to see - [x] Mock sas9 services and check it's pages
mihajlo added 1 commit 2024-05-08 14:51:30 +00:00
feat(dark mode): refactoring clarity to enable dark mode, added toggle button
Some checks failed
Build / Build-and-ng-test (pull_request) Failing after 51s
Details
5564aea9c2
mihajlo changed title from Dark Mode to WIP: Dark Mode 2024-05-08 14:51:34 +00:00
mihajlo added 1 commit 2024-05-22 11:30:32 +00:00
Merge branch 'main' into issue98
Some checks failed
Build / Build-and-ng-test (pull_request) Failing after 51s
Details
59d46a9926
mihajlo added 2 commits 2024-05-23 14:17:10 +00:00
chore(git): Merge branch 'issue98' of ssh://git.datacontroller.io:29419/dc/dc into issue98
Some checks failed
Build / Build-and-ng-test (pull_request) Failing after 51s
Details
da522c557d
mihajlo added 1 commit 2024-05-23 14:17:21 +00:00
Merge branch 'main' into issue98
Some checks failed
Build / Build-and-ng-test (pull_request) Failing after 51s
Details
cb9a5f0eb4
mihajlo added 1 commit 2024-05-28 19:17:43 +00:00
feat(dark mode): clarity optimizations
Some checks failed
Build / Build-and-ng-test (pull_request) Failing after 50s
Details
afa7e380aa
mihajlo added 2 commits 2024-05-29 12:36:23 +00:00
style: lint
Some checks failed
Build / Build-and-ng-test (pull_request) Failing after 1m15s
Details
31c90f3190
mihajlo added 2 commits 2024-05-29 14:22:02 +00:00
style: lint
Some checks failed
Build / Build-and-ng-test (pull_request) Failing after 1m17s
Details
4330da520f
mihajlo added 1 commit 2024-05-29 14:26:31 +00:00
chore: prettier version
Some checks failed
Build / Build-and-ng-test (pull_request) Failing after 1m16s
Details
85909cfc1e
mihajlo changed title from WIP: Dark Mode to Dark Mode 2024-05-29 14:26:54 +00:00
sabir requested changes 2024-05-30 05:54:38 +00:00
client/src/app/metadata/metadata.component.ts Outdated
@ -153,0 +155,4 @@
* clicking on the input inside of the clr-tree-view
* This is workaround
*/
public stealFocusFix(event: any) {
sabir commented 2024-05-30 05:48:01 +00:00
Collaborator
Copy Link

I saw this function in almost every component. Can you do something to reduce code duplication?
Probably create a utility component for this clr-tree-view with input and use that in other components

I saw this function in almost every component. Can you do something to reduce code duplication? Probably create a utility component for this clr-tree-view with input and use that in other components
mihajlo commented 2024-05-30 07:24:47 +00:00
Author
Owner
Copy Link

Great point, angular directive will come in handy with this one.

Great point, angular directive will come in handy with this one.
mihajlo marked this conversation as resolved
yury approved these changes 2024-05-30 07:46:13 +00:00
client/src/app/app.component.scss
@ -196,1 +154,3 @@
color: #fff;
body[cds-theme="light"] {
.btn-primary .btn, .btn.btn-primary {
border-color: #314351;
yury commented 2024-05-30 07:20:55 +00:00
Collaborator
Copy Link

it would be useful to have variables for colors.

it would be useful to have variables for colors.
mihajlo marked this conversation as resolved
client/src/app/group/group.component.scss Outdated
@ -29,3 +64,3 @@
.member-table{
background-color: #f9f9f9;
// background-color: #f9f9f9;
yury commented 2024-05-30 07:27:58 +00:00
Collaborator
Copy Link

please cleanup

please cleanup
mihajlo marked this conversation as resolved
client/src/styles.scss Outdated
@ -15,0 +39,4 @@
}
}
// body::-webkit-scrollbar {
yury commented 2024-05-30 07:45:40 +00:00
Collaborator
Copy Link

please cleanup

please cleanup
mihajlo marked this conversation as resolved
mihajlo added 2 commits 2024-05-30 07:47:44 +00:00
style: lint
Some checks failed
Build / Build-and-ng-test (pull_request) Failing after 1m16s
Details
e98f288302
mihajlo added 1 commit 2024-05-30 10:03:16 +00:00
fix: added colors.scss file, start of a refactor
Some checks failed
Build / Build-and-ng-test (pull_request) Failing after 1m15s
Details
110ad9a6e9
mihajlo added 1 commit 2024-05-30 12:12:03 +00:00
chore: sheet crypto package fix
Some checks failed
Build / Build-and-ng-test (pull_request) Failing after 1m16s
Details
bad43135d7
mihajlo added 1 commit 2024-05-30 12:22:05 +00:00
ci: fix
Some checks failed
Build / Build-and-ng-test (pull_request) Failing after 1m14s
Details
68a2a606f3
mihajlo added 1 commit 2024-05-30 12:46:14 +00:00
ci: fix
Some checks failed
Build / Build-and-ng-test (pull_request) Failing after 1m39s
Details
978f152ab6
mihajlo added 1 commit 2024-05-30 12:52:57 +00:00
ci: fix
Some checks failed
Build / Build-and-ng-test (pull_request) Failing after 1m13s
Details
5f7c7fcc7b
mihajlo added 1 commit 2024-05-30 12:56:59 +00:00
ci: fix
Some checks failed
Build / Build-and-ng-test (pull_request) Failing after 1m14s
Details
d14a4eaadd
mihajlo added 1 commit 2024-05-30 13:49:55 +00:00
ci: fix
Some checks failed
Build / Build-and-ng-test (pull_request) Failing after 1m13s
Details
0a9e5dd834
mihajlo added 1 commit 2024-05-30 13:54:00 +00:00
ci: fix
All checks were successful
Build / Build-and-ng-test (pull_request) Successful in 4m43s
Details
6e631cd9a5
mihajlo added 1 commit 2024-05-30 13:57:25 +00:00
ci: fix
All checks were successful
Build / Build-and-ng-test (pull_request) Successful in 4m42s
Details
d7732ed206
allan merged commit d8b95c5739 into main 2024-05-31 09:21:07 +00:00
allan deleted branch issue98 2024-05-31 09:21:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
sabir
yury
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: dc/dc#102
No description provided.
Delete Branch "issue98"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?