Compare commits

...

2 Commits

Author SHA1 Message Date
a156c0111b fix: adding SYSSITE, part of #116
All checks were successful
Release / Build-production-and-ng-test (push) Successful in 3m54s
Release / Build-and-test-development (push) Successful in 8m12s
Release / release (push) Successful in 8m25s
2024-07-02 16:03:26 +01:00
e5d93fd7d6 fix: ensuring review_reason_txt in output. Closes #117 2024-07-02 16:02:58 +01:00
3 changed files with 16 additions and 4 deletions

View File

@ -105,8 +105,6 @@ create view work.submits as
,a.submitted_by_nm as submitter ,a.submitted_by_nm as submitter
,put(a.REVIEWED_ON_DTTM,yymmddhhmmss.) as REVIEWED ,put(a.REVIEWED_ON_DTTM,yymmddhhmmss.) as REVIEWED
,a.submit_status_cd as status ,a.submit_status_cd as status
,a.reviewed_on_dttm
,a.reviewed_by_nm as approver
from &mpelib..mpe_submit(where=(submit_status_cd ne 'SUBMITTED')) a from &mpelib..mpe_submit(where=(submit_status_cd ne 'SUBMITTED')) a
%macro gethistory(); %macro gethistory();
@ -120,8 +118,18 @@ create view work.submits as
%end; %end;
%mend gethistory; %mend gethistory;
%gethistory() %gethistory()
;
order by a.submitted_on_dttm desc; /* get latest reason text */
create table work.reviews as
select a.*
,b.reviewed_on_dttm
,b.reviewed_by_nm as approver
,b.review_reason_txt
from work.submits a
left join &mpelib..mpe_review b
on a.table_id=b.table_id
order by a.table_id desc, b.reviewed_on_dttm desc;
%mp_abort(iftrue= (&syscc > 0) %mp_abort(iftrue= (&syscc > 0)
,mac=&_program ,mac=&_program
@ -129,7 +137,9 @@ create view work.submits as
) )
data work.fromsas; data work.fromsas;
set work.submits; set work.reviews;
by descending table_id descending reviewed_on_dttm;
if first.table_id;
if _n_ ge &startrow; if _n_ ge &startrow;
n+1; n+1;
if n>&hist then stop; if n>&hist then stop;

View File

@ -188,6 +188,7 @@ data _null_;
put "<li> METAPERSON: " metaperson "</li>"; put "<li> METAPERSON: " metaperson "</li>";
put "<li> METAUSER: " metauser "</li>"; put "<li> METAUSER: " metauser "</li>";
put "<li> SYSUSERID: " sysuserid "</li>"; put "<li> SYSUSERID: " sysuserid "</li>";
put "<li> SYSSITE: &syssite</li>";
url='/SASStoredProcess/do'; url='/SASStoredProcess/do';
end; end;
else do; else do;

View File

@ -222,6 +222,7 @@ data _null_;
put "<li> SYSUSERID: " sysuserid "</li>"; put "<li> SYSUSERID: " sysuserid "</li>";
put "<li> SYSHOSTNAME: &syshostname</li>"; put "<li> SYSHOSTNAME: &syshostname</li>";
put "<li> SYSVLONG: &sysvlong</li>"; put "<li> SYSVLONG: &sysvlong</li>";
put "<li> SYSSITE: &syssite</li>";
run; run;
data _null_; data _null_;