dc/dc
dc/dc
3
1
Fork 0
Code Issues 16 Pull Requests 1 Actions Packages Projects Releases 35 Wiki Activity

fix: ensuring review_reason_txt in output. Closes #117

Browse Source
This commit is contained in:
allan 2024-07-02 16:02:58 +01:00
parent b712f851a2
commit e5d93fd7d6
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
sas/sasjs/services/approvers/gethistory.sas
View File

@ -105,8 +105,6 @@ create view work.submits as
,a.submitted_by_nm as submitter
,put(a.REVIEWED_ON_DTTM,yymmddhhmmss.) as REVIEWED
,a.submit_status_cd as status
,a.reviewed_on_dttm
,a.reviewed_by_nm as approver
from &mpelib..mpe_submit(where=(submit_status_cd ne 'SUBMITTED')) a
%macro gethistory();
@ -120,8 +118,18 @@ create view work.submits as
%end;
%mend gethistory;
%gethistory()
;
order by a.submitted_on_dttm desc;
/* get latest reason text */
create table work.reviews as
select a.*
,b.reviewed_on_dttm
,b.reviewed_by_nm as approver
,b.review_reason_txt
from work.submits a
left join &mpelib..mpe_review b
on a.table_id=b.table_id
order by a.table_id desc, b.reviewed_on_dttm desc;
%mp_abort(iftrue= (&syscc > 0)
,mac=&_program
@ -129,7 +137,9 @@ create view work.submits as
)
data work.fromsas;
set work.submits;
set work.reviews;
by descending table_id descending reviewed_on_dttm;
if first.table_id;
if _n_ ge &startrow;
n+1;
if n>&hist then stop;