dc/dc
dc/dc
4
1
Fork 0
Code Issues 16 Pull Requests Actions Packages Projects Releases 48 Wiki Activity

fix: improving accessibility lighthouse score

Browse Source
This commit is contained in:
Mihajlo Medjedovic 2025-03-21 14:08:24 +01:00
parent 69f883034f
commit 7f3577c3ef
17 changed files with 32 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
client/src/app/app.component.html
View File

@ -139,10 +139,11 @@
[routerLink]="['/']"
class="nav-link"
>
<img class="without-text d-block d-md-none" src="images/dc-logo.svg" />
<img class="without-text d-block d-md-none" src="images/dc-logo.svg" alt="datacontroller logo without text"/>
<img
class="with-text d-none d-md-block"
src="images/datacontroller.svg"
alt="datacontroller logo"
/>
</a>
@ -283,7 +284,7 @@
<!-- App Loading Page -->
<div *ngIf="!startupDataLoaded" class="app-loading">
<img class="loading-logo" src="images/datacontroller.svg" />
<img class="loading-logo" src="images/datacontroller.svg" alt="datacontroller logo"/>
<div *ngIf="appActive === null" class="slider">
<div class="line"></div>

4
client/src/app/app.component.scss
View File

@ -98,7 +98,7 @@ header {
}
.nav-link.active {
background: #61717D;
background: #1d2f3d;
}
}
@ -444,4 +444,4 @@ header {
padding: 0rem 0rem 0rem 0rem;
}
}
}

1
client/src/app/editor/editor.component.html
View File

@ -200,6 +200,7 @@
clrTooltipTrigger
(click)="datasetInfo = true"
shape="info-circle"
aria-label="View dataset meta info"
class="is-highlight cursor-pointer"
size="24"
></clr-icon>

3
client/src/app/editor/editor.component.scss
View File

@ -225,6 +225,7 @@ hot-table {
.view-table {
font-size: inherit !important;
color: #1a57bb !important;
}
// When width is smaller remove the text from the buttons
@ -243,4 +244,4 @@ hot-table {
// we will remove it if no issues found
// .filter-modal {
// z-index: 1210;
// }
// }

2
client/src/app/home/home.component.html
View File

@ -123,7 +123,7 @@
</div>
<div *ngIf="!loading" class="no-table-selected">
<img src="images/select-table.png" class="select-table-icon"/>
<img src="images/select-table.png" class="select-table-icon" alt="select table icon"/>
<p
*ngIf="treeNodeLibraries?.length! > 0"
class="text-center color-gray mt-10"

2
client/src/app/multi-dataset/multi-dataset.component.html
View File

@ -127,7 +127,7 @@
class="no-table-selected pointer-events-none"
>
<clr-icon
shape="warning-standard"
shape="upload-cloud"
size="40"
class="is-info icon-dc-fill"
></clr-icon>

1
client/src/app/review/approve/approve.component.html
View File

@ -89,6 +89,7 @@
<clr-dg-cell class="p-0 d-flex justify-content-center">
<button
class="btn btn-success"
aria-label="Download audit file"
[id]="approveItem.tableId"
(click)="
download(approveItem.tableId); $event.stopPropagation()

3
client/src/app/review/history/history.component.html
View File

@ -47,7 +47,7 @@
</table>
</div>
<div class="modal-footer">
<button type="button" class="btn btn-outline" (click)="openModal = false">
<button type="button" aria-label="Close modal" class="btn btn-outline" (click)="openModal = false">
OK
</button>
</div>
@ -119,6 +119,7 @@
<clr-dg-cell class="verCenter">{{ historyItem.reviewed }}</clr-dg-cell>
<clr-dg-cell class="verCenter p-0 d-flex justify-content-center">
<button
aria-label="Download audit file"
class="btn btn-success"
(click)="download(historyItem.tableId); $event.stopPropagation()"
>

3
client/src/app/review/submitter/submitter.component.html
View File

@ -64,7 +64,7 @@
<!-- <clr-dg-cell>{{sub.approver}}</clr-dg-cell> -->
<clr-dg-cell>{{ sub.submitReason }}</clr-dg-cell>
<clr-dg-cell>
<div class="row justify-content-around" role="tooltip">
<div class="row justify-content-around" role="tooltip" aria-label="Go to staged data screen">
<a
class="column-center links tooltip tooltip-md tooltip-bottom-left color-blue"
(click)="goToStage(sub.tableId)"
@ -79,6 +79,7 @@
<clr-dg-cell class="p-0 d-flex justify-content-center">
<button
class="btn btn-success"
aria-label="Download audit file for table record"
(click)="download(sub.tableId); $event.stopPropagation()"
>
<clr-icon shape="download"></clr-icon>

4
client/src/app/shared/login/login.component.html
View File

@ -1,13 +1,13 @@
<div class="login-sidebar-wrapper" [class.active]="isActive">
<div class="login-sidebar sideBarProps">
<!--img src="images/data_controller.png" alt=""-->
<img class="login-logo" src="images/datacontroller.svg" alt="" />
<img class="login-logo" src="images/datacontroller.svg" alt="datacontroller logo" />
<form class="login" (ngSubmit)="submit()">
<label class="title">
<h3 class="welcome">Welcome to</h3>
Data Controller
<h5 class="hint">Capture, Review, and Approve</h5>
<h4 class="hint">Capture, Review, and Approve</h4>
</label>
<div class="login-group">
<input

4
client/src/app/shared/login/login.component.scss
View File

@ -111,7 +111,7 @@
}
::ng-deep .login-sidebar-wrapper .login-group {
.clr-control-container, .username, .password {
.clr-control-container, .clr-input-group, .username, .password {
width: 100%;
}
@ -126,4 +126,4 @@
.login-logo {
max-width: 200px
}
}

4
client/src/app/shared/sidebar/sidebar.component.html
View File

@ -11,7 +11,7 @@
class="d-flex justify-content-center sub-dropdown"
>
<clr-dropdown>
<button class="dropdown-toggle btn btn-link" clrDropdownTrigger>
<button class="dropdown-toggle btn btn-primary" clrDropdownTrigger>
{{ getSubPage() }}
<clr-icon shape="caret down"></clr-icon>
</button>
@ -113,7 +113,7 @@
class="d-flex justify-content-center sub-dropdown"
>
<clr-dropdown>
<button class="dropdown-toggle btn btn-link" clrDropdownTrigger>
<button class="dropdown-toggle btn btn-primary" clrDropdownTrigger>
{{ getSubPage() }}
<clr-icon shape="caret down"></clr-icon>
</button>

2
client/src/app/shared/sidebar/sidebar.component.scss
View File

@ -79,4 +79,4 @@ clr-vertical-nav {
bottom: 0;
top: 0;
}
}
}

2
client/src/app/shared/user-nav-dropdown/header-actions.component.html
View File

@ -26,7 +26,7 @@
<button class="nav-text color-white user-nav-toggle" clrDropdownToggle>
<span>{{ userName }}</span>
<span *ngIf="userName !== 'Not logged in' && isViya"
><img class="avatar-img" src="{{ getPictureUrl() }}" alt=""
><img class="avatar-img" src="{{ getPictureUrl() }}" alt="profile picture"
/></span>
<span
class="badge badge-danger"

5
client/src/app/viewer/viewer.component.html
View File

@ -375,6 +375,7 @@
<clr-icon
clrTooltipTrigger
(click)="datasetInfo = true"
aria-label="View dataset meta info"
shape="info-circle"
class="is-highlight cursor-pointer"
size="24"
@ -480,7 +481,7 @@
*ngIf="!lib && !table && !noDataReqErr && !noData"
class="no-table-selected"
>
<img src="images/select-library.png" class="select-table-icon"/>
<img src="images/select-library.png" class="select-table-icon" alt="select a library icon"/>
<h3 class="text-center color-gray mt-10" cds-text="section">
Please select a library
</h3>
@ -516,7 +517,7 @@
*ngIf="libinfo !== null"
class="no-table-selected-info pointer-events-none"
>
<img src="images/select-table.png" class="select-table-icon"/>
<img src="images/select-table.png" class="select-table-icon" alt="select table icon"/>
<p class="text-center color-gray mt-10" cds-text="section">
Please select a table
</p>

14
client/src/app/xlmap/xlmap.component.html
View File

@ -45,11 +45,7 @@
<div class="content-area">
<div *ngIf="!selectedXLMap" class="no-table-selected">
<clr-icon
shape="warning-standard"
size="60"
class="is-info icon-dc-fill"
></clr-icon>
<img src="images/select-table.png" class="select-table-icon" alt="select table icon"/>
<p
*ngIf="xlmaps.length > 0"
class="text-center color-gray mt-10"
@ -101,7 +97,7 @@
<i class="d-flex clr-col-12 clr-justify-content-center mt-5-i">{{
selectedXLMap.description
}}</i>
<h5 class="d-flex clr-col-12 clr-justify-content-center mt-5-i">
<p class="d-flex clr-col-12 clr-justify-content-center mt-5-i">
Rules Source:
<a
cds-text="labelLink"
@ -110,8 +106,8 @@
>
{{ rulesSource }}
</a>
</h5>
<h5 class="d-flex clr-col-12 clr-justify-content-center mt-5-i">
</p>
<p class="d-flex clr-col-12 clr-justify-content-center mt-5-i">
Target dataset:
<a
cds-text="labelLink"
@ -120,7 +116,7 @@
>
{{ selectedXLMap.targetDS }}
</a>
</h5>
</p>
</div>
<div class="clr-flex-1">

2
client/src/index.html
View File

@ -1,5 +1,5 @@
<!doctype html>
<html>
<html lang="en">
<head>
<meta charset="utf-8" />
<title>Data Controller</title>