#5 documented the row count next to the table name as "the number of rows the search matched, which can be higher than the number of rows displayed". Measured against a live Viya estate, that is not what a search does.
Searching a 1200-row table for a value present in every row:
rows reported
rows returned
search (1200 matches)
500
499
plain view, no search
1200
500
For a search, both numbers stop at DC_MAXOBS_WEBVIEW - the count is the capped count, not the match total. The "count higher than displayed" behaviour belongs to the unsearched view, not to the search. (The 499 came from an off-by-one in the search branch of viewdata.sas, fixed separately.)
The bullet now reads:
The result set is capped by the DC_MAXOBS_WEBVIEW option (500 rows by default). A search that matches more rows than the cap returns the first 500, and the row count shown next to the table name is that capped count, not the total number of matches.
Everything else added by #5 held up against the same estate - the case sensitive CONTAINS wording (Smith finds Smithson, smith finds Goldsmith, smith does not find Smithson), the exact numeric match, every-column coverage, the filter scoping, the no-data panel text, and the screenshot.
Follow-up to #5, which was merged before this correction could be added to it.
#5 documented the row count next to the table name as "the number of rows the search matched, which can be higher than the number of rows displayed". Measured against a live Viya estate, that is not what a search does.
Searching a 1200-row table for a value present in every row:
| | rows reported | rows returned |
|---|---|---|
| search (1200 matches) | 500 | 499 |
| plain view, no search | 1200 | 500 |
For a search, both numbers stop at `DC_MAXOBS_WEBVIEW` - the count is the capped count, not the match total. The "count higher than displayed" behaviour belongs to the unsearched view, not to the search. (The 499 came from an off-by-one in the search branch of `viewdata.sas`, fixed separately.)
The bullet now reads:
> The result set is capped by the `DC_MAXOBS_WEBVIEW` option (500 rows by default). A search that matches more rows than the cap returns the first 500, and the row count shown next to the table name is that capped count, not the total number of matches.
Everything else added by #5 held up against the same estate - the case sensitive CONTAINS wording (`Smith` finds `Smithson`, `smith` finds `Goldsmith`, `smith` does not find `Smithson`), the exact numeric match, every-column coverage, the filter scoping, the no-data panel text, and the screenshot.
Follow-up to #5, which was merged before this correction could be added to it.
The row count next to the table name is the capped count, not the total
number of matches. A search that matches more rows than DC_MAXOBS_WEBVIEW
returns the first 500 and reports 500, so the count does not rise above the
cap even when many more rows match.
You are not authorized to merge this pull request.
This pull request can be merged automatically.
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
#5 documented the row count next to the table name as "the number of rows the search matched, which can be higher than the number of rows displayed". Measured against a live Viya estate, that is not what a search does.
Searching a 1200-row table for a value present in every row:
For a search, both numbers stop at
DC_MAXOBS_WEBVIEW- the count is the capped count, not the match total. The "count higher than displayed" behaviour belongs to the unsearched view, not to the search. (The 499 came from an off-by-one in the search branch ofviewdata.sas, fixed separately.)The bullet now reads:
Everything else added by #5 held up against the same estate - the case sensitive CONTAINS wording (
SmithfindsSmithson,smithfindsGoldsmith,smithdoes not findSmithson), the exact numeric match, every-column coverage, the filter scoping, the no-data panel text, and the screenshot.Follow-up to #5, which was merged before this correction could be added to it.
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.