dc
c8c0858295
sas/.sasjslint now promotes noUnusedMacros to "error", so the rule fails
the build rather than printing a warning. The 54 findings it reported are
gone:
- 46 header entries nothing calls are dropped. Each removal was checked
against the compiled artefacts rather than the linter alone: the
project was compiled before and after, and the two sasjsbuild trees
compared. 37 macro definitions disappear from the generated programs -
every one of them either a duplicate of a definition the file still
reaches through another declared macro, or a macro no generated program
calls. No macro that a generated program calls lost its definition.
- 8 entries are kept, in five files that carry
@sasjslint {"noUnusedMacros": false} with the reason written above it:
the three serviceInit programs and serviceterm.sas declare mpeinit and
mpeterm without calling them, because that declaration is how a service
body reaches those macros at all; loadfile.sas declares mp_binarycopy
for the fallback that is commented out on SAS 9.4 and later.
- Four headers are left with no macros to declare, so their empty
<h4> SAS Macros </h4> section is removed rather than kept as a stub.
@sasjs/cli is bumped 6.2.0 -> 6.5.0 in sas/package.json. The lint engine
ships inside the CLI and is not a direct dependency, so the pinned CLI is
what fixes the rule set: 6.2.0 resolves @sasjs/lint 4.3.0, 6.5.0 pins
4.9.0 exactly. Both versions were compiled against this tree and the
sasjsbuild output is byte-identical, so the bump changes the lint engine
and nothing else.
`sasjs lint` is also now reachable as `npm run lint:sas`, and a CI step in
build.yaml runs it. Until now nothing ran SAS lint automatically, and a
bare `sasjs` resolves whatever CLI is installed globally - a different
lint version reports a different rule set, which is why the counts in
issue #376 (taken with 6.2.5) do not match the pinned 6.2.0.
43 warnings remain under the rules not yet promoted: noUndeclaredMacros
(25), noBannedStrings (13), macro name length and case (4),
indentationMultiple (1). They are the next rungs of the ratchet.
The pre-commit Prettier gate could not run: it needs client/node_modules,
which this worktree does not install, and the fix it attempted touched
three client files that this change does not modify (reverted). No client
file is in this commit.
99 lines
2.0 KiB
SAS
99 lines
2.0 KiB
SAS
/**
|
|
@file
|
|
@brief testing getchangeinfo service
|
|
|
|
<h4> SAS Macros </h4>
|
|
@li mx_execute.sas
|
|
@li mp_assert.sas
|
|
@li mf_getuniquefileref.sas
|
|
|
|
**/
|
|
|
|
%let _program=&appLoc/services/public/getchangeinfo;
|
|
|
|
/**
|
|
* First part - stage some data (for diffing)
|
|
*/
|
|
data work.sascontroltable;
|
|
action='LOAD';
|
|
message="getdiffs prep";
|
|
libds="&dclib..MPE_X_TEST";
|
|
output;
|
|
stop;
|
|
run;
|
|
proc sql noprint;
|
|
select max(primary_key_field) into: maxpk from &dclib..mpe_x_test;
|
|
data work.jsdata;
|
|
set &dclib..mpe_x_test(rename=(
|
|
some_date=dt2 SOME_DATETIME=dttm2 SOME_TIME=tm2)
|
|
);
|
|
/* for now, the adapter sends these as strings */
|
|
some_date=put(dt2,date9.);
|
|
SOME_DATETIME=put(dttm2,datetime19.);
|
|
some_time=put(tm2,time.);
|
|
drop dt2 dttm2 tm2;
|
|
_____DELETE__THIS__RECORD_____='No';
|
|
if _n_=1 then do;
|
|
primary_key_field=sum(&maxpk,1);
|
|
some_char=' leadingblanks';
|
|
some_num=._;
|
|
output;
|
|
end;
|
|
else if _n_<3 then do;
|
|
SOME_NUM=ranuni(0);
|
|
end;
|
|
else stop;
|
|
run;
|
|
|
|
%mx_execute(&appLoc/services/editors/stagedata,
|
|
viyacontext=&defaultcontext,
|
|
inputdatasets=work.jsdata work.sascontroltable,
|
|
outlib=web1,
|
|
mdebug=&sasjs_mdebug
|
|
)
|
|
|
|
%let status=0;
|
|
data work.sasparams;
|
|
set web1.sasparams;
|
|
putlog (_all_)(=);
|
|
if status='SUCCESS' then call symputx('status',1);
|
|
call symputx('dsid',dsid);
|
|
run;
|
|
%mp_assert(
|
|
iftrue=(&status=1 and &syscc=0),
|
|
desc=Checking successful submission
|
|
)
|
|
|
|
|
|
/* now call getchangeinfo */
|
|
%let f3=%mf_getuniquefileref();
|
|
data _null_;
|
|
file &f3 termstr=crlf;
|
|
put 'TABLE:$43.';
|
|
put "&dsid";
|
|
run;
|
|
%mx_execute(&_program,
|
|
viyacontext=&defaultcontext,
|
|
inputfiles=&f3:sascontroltable,
|
|
outlib=web3,
|
|
mdebug=&sasjs_mdebug
|
|
)
|
|
|
|
data work.jsparams;
|
|
set web3.jsparams;
|
|
putlog (_all_)(=);
|
|
call symputx('ALLOW_RESTORE',ALLOW_RESTORE);
|
|
run;
|
|
%mp_assert(
|
|
iftrue=(&syscc=0),
|
|
desc=Checking successful execution
|
|
)
|
|
%mp_assert(
|
|
iftrue=(%mf_nobs(work.jsparams)=1),
|
|
desc=Checking data was returned
|
|
)
|
|
%mp_assert(
|
|
iftrue=(&ALLOW_RESTORE=NO),
|
|
desc=Checking admin user cannot restore - as table was not approved
|
|
)
|