Follows dc/dc PR #343, which makes the Delete? column client-owned: editors/getdata no longer sends _____DELETE__THIS__RECORD_____, the editor creates it, and a response that carries the name is refused.
Changes
docs/developer-guide/filter-pre-edit-hook.md
The example's re-read data step no longer sets _____DELETE__THIS__RECORD_____="No". It mirrored the data step getdata.sas used to run; that column is created by the editor itself and is never a column of the dataset.
The "What the hook does" bullet says so explicitly, and that a response carrying the name is refused.
docs/dcc-tables.md
A note that _____DELETE__THIS__RECORD_____ is a reserved name: the editor creates that column itself and never reads it from the table, so a target table must not contain a column of that name - the editor refuses to open one that does.
docs/dc-userguide.md
The Delete? description now says the column is created by Data Controller and is not part of the table.
Verification
mkdocs build --clean succeeds (the absolute link ... left as is INFO lines are pre-existing), and the three edits render: the reserved-name admonition on the MPE_TABLES page, the userguide sentence, and the Developer Guide's updated prose and example.
The upload contract is unchanged - excel.md and files.md still describe _____DELETE__THIS__RECORD_____ as an optional column in an uploaded file.
Follows dc/dc PR #343, which makes the **Delete?** column client-owned: `editors/getdata` no longer sends `_____DELETE__THIS__RECORD_____`, the editor creates it, and a response that carries the name is refused.
## Changes
**`docs/developer-guide/filter-pre-edit-hook.md`**
- The example's re-read data step no longer sets `_____DELETE__THIS__RECORD_____="No"`. It mirrored the data step `getdata.sas` used to run; that column is created by the editor itself and is never a column of the dataset.
- The "What the hook does" bullet says so explicitly, and that a response carrying the name is refused.
**`docs/dcc-tables.md`**
- A note that `_____DELETE__THIS__RECORD_____` is a reserved name: the editor creates that column itself and never reads it from the table, so a target table must not contain a column of that name - the editor refuses to open one that does.
**`docs/dc-userguide.md`**
- The Delete? description now says the column is created by Data Controller and is not part of the table.
## Verification
`mkdocs build --clean` succeeds (the `absolute link ... left as is` INFO lines are pre-existing), and the three edits render: the reserved-name admonition on the MPE_TABLES page, the userguide sentence, and the Developer Guide's updated prose and example.
The upload contract is unchanged - `excel.md` and `files.md` still describe `_____DELETE__THIS__RECORD_____` as an optional column in an uploaded file.
The pre-edit hook example re-added _____DELETE__THIS__RECORD_____="No" when
it re-read the table, mirroring the data step getdata.sas used to run. That
column is created by the editor itself (it is the Delete? column) and is
never part of the dataset, so the example no longer adds it - and a response
that carries the name is refused by the editor, which the "What the hook
does" bullet now states.
Also notes the reserved name on the MPE_TABLES page, and says in the user
guide that the Delete? column is created by Data Controller rather than
being part of the table.
Reviewed the full diff at 21fcf2d (three markdown files documenting the client-owned delete-record column) against the implementing change in dc/dc #343.
Cross-checked each claim against the code: the editor-side refusal is real (prepareDeleteRecordColumn throws on a response carrying DELETE__THIS__RECORD, which is what a target table with that column name produces), the sample hook at docs/developer-guide/filter-pre-edit-hook.md:103 no longer re-adds the column and the note at line 132 states the new contract exactly, and the reserved-name note in docs/dcc-tables.md:20 matches the guard. mkdocs nav already covers all three files.
No blocking issues.
Reviewed the full diff at 21fcf2d (three markdown files documenting the client-owned delete-record column) against the implementing change in dc/dc #343.
Cross-checked each claim against the code: the editor-side refusal is real (prepareDeleteRecordColumn throws on a response carrying _____DELETE__THIS__RECORD_____, which is what a target table with that column name produces), the sample hook at docs/developer-guide/filter-pre-edit-hook.md:103 no longer re-adds the column and the note at line 132 states the new contract exactly, and the reserved-name note in docs/dcc-tables.md:20 matches the guard. mkdocs nav already covers all three files.
No blocking issues.
allan
merged commit 2b60c7443b into main2026-10-18 09:53:47 +00:00
allan
deleted branch docs/delete-record-column-client-side2026-10-18 09:53:47 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
hermes
Follows dc/dc PR #343, which makes the Delete? column client-owned:
editors/getdatano longer sends_____DELETE__THIS__RECORD_____, the editor creates it, and a response that carries the name is refused.Changes
docs/developer-guide/filter-pre-edit-hook.md_____DELETE__THIS__RECORD_____="No". It mirrored the data stepgetdata.sasused to run; that column is created by the editor itself and is never a column of the dataset.docs/dcc-tables.md_____DELETE__THIS__RECORD_____is a reserved name: the editor creates that column itself and never reads it from the table, so a target table must not contain a column of that name - the editor refuses to open one that does.docs/dc-userguide.mdVerification
mkdocs build --cleansucceeds (theabsolute link ... left as isINFO lines are pre-existing), and the three edits render: the reserved-name admonition on the MPE_TABLES page, the userguide sentence, and the Developer Guide's updated prose and example.The upload contract is unchanged -
excel.mdandfiles.mdstill describe_____DELETE__THIS__RECORD_____as an optional column in an uploaded file.Reviewed the full diff at
21fcf2d(three markdown files documenting the client-owned delete-record column) against the implementing change in dc/dc #343.Cross-checked each claim against the code: the editor-side refusal is real (prepareDeleteRecordColumn throws on a response carrying DELETE__THIS__RECORD, which is what a target table with that column name produces), the sample hook at docs/developer-guide/filter-pre-edit-hook.md:103 no longer re-adds the column and the note at line 132 states the new contract exactly, and the reserved-name note in docs/dcc-tables.md:20 matches the guard. mkdocs nav already covers all three files.
No blocking issues.