From 856e57173fa3fd9e2bddfb0e68a9a2c2b080afdf Mon Sep 17 00:00:00 2001 From: dc Date: Mon, 26 Oct 2026 11:57:21 +0000 Subject: [PATCH] docs(overview): the EDIT limits truncate, and the viewer default is 2000 not 500 Review 431: dc-overview.md still said "Up to 500 rows can be edited (in the web editor) at one time" - the wrong number (DC_MAXOBS_WEBEDIT ships at 250) and, once dc/dc#352 lands, the wrong behaviour (an over-limit selection is served truncated with a warning, not refused or capped at a count). It now names both limits, whichever binds first, and links to the options that set them. Sweeping for the same stale figure turned up dcu-tableviewer.md, which says 500 twice and uses 500 in its worked example of the row count above the grid. DC_MAXOBS_WEBVIEW has been 2000 since 20261003_row_and_cell_limits.sas (the migration records 500 -> 2000), and mpe_makedata seeds 2000, so those three places were two releases out of date. Fixed here, and flagged in the PR reply as VIEW rather than EDIT in case it belongs in its own change. Checked: no "500 rows" or stale abort wording left in docs/, and the two anchors the overview now links to (dc_maxobs_webedit, dc_maxcells_webedit) exist on the published options page. --- docs/dc-overview.md | 4 +++- docs/dcu-tableviewer.md | 8 ++++---- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/docs/dc-overview.md b/docs/dc-overview.md index d2177a5..525da56 100644 --- a/docs/dc-overview.md +++ b/docs/dc-overview.md @@ -35,7 +35,9 @@ When importing an excel file, all rows are loaded into the web page. You have a A CSV upload bypasses the part where the records are loaded into the web page, and ALL rows are sent to the staging area directly. This makes it suitable for larger uploads. ## Edit Stage Approve Workflow -Up to 500 rows can be edited (in the web editor) at one time. These edits are submitted to a staging area. After one or more approvals (acceptances) the changes are applied to the source table. +The EDIT screen loads up to [DC_MAXOBS_WEBEDIT](/dcc-options/#dc_maxobs_webedit) rows (250 by default), or as many rows as fit within [DC_MAXCELLS_WEBEDIT](/dcc-options/#dc_maxcells_webedit) (200,000 cells) - whichever is reached first, so a wide table loads fewer rows than a narrow one. A larger table is not refused: it loads truncated, with a warning against the table name, and the filter is the way to reach the rest. + +These edits are submitted to a staging area. After one or more approvals (acceptances) the changes are applied to the source table. ![screenshot](img/dcu_flow.png) diff --git a/docs/dcu-tableviewer.md b/docs/dcu-tableviewer.md index 7a97ac3..95b4294 100644 --- a/docs/dcu-tableviewer.md +++ b/docs/dcu-tableviewer.md @@ -1,7 +1,7 @@ # Data Controller for SAS: Viewer The viewer screen provides a raw view of the underlying table. -Choose a library, then a table, and click view to see the first 500 rows. +Choose a library, then a table, and click view to see the first rows - up to the `DC_MAXOBS_WEBVIEW` limit, 2,000 rows by default. A filter option is provided should you wish to view a different section of rows. The following libraries will be visible: @@ -21,9 +21,9 @@ The search covers **every** column of the table at once, so you do not need to k - **Character search** (the default) is a case sensitive CONTAINS match against every character column, so `Smith` finds `Smithson` and `smith` finds `Goldsmith`, but `smith` will not find `Smithson`. - **Numeric search** (tick the Numeric box) is an exact match against every numeric column, so `42` will not find `420` or `4210`. - If a filter is applied, the search runs within the filtered rows rather than the whole table. -- The grid is capped by the [`DC_MAXOBS_WEBVIEW`](/dcc-options/#dc_maxobs_webview) option (500 rows by default). -- For a search, the cap applies to the row count as well: a search that matches more rows than the cap returns 500 of them, and the count shown next to the table name is the number of rows returned, not the total number of matches. -- Without a search, the count shown next to the table name is the full number of rows in the filtered view, so it can be higher than the number of rows displayed - a table of 1,200 rows reports `1,200 rows` above a grid holding the first 500. +- The grid is capped by the [`DC_MAXOBS_WEBVIEW`](/dcc-options/#dc_maxobs_webview) option (2,000 rows by default). +- For a search, the cap applies to the row count as well: a search that matches more rows than the cap returns 2,000 of them, and the count shown next to the table name is the number of rows returned, not the total number of matches. +- Without a search, the count shown next to the table name is the full number of rows in the filtered view, so it can be higher than the number of rows displayed - a table of 5,000 rows reports `5,000 rows` above a grid holding the first 2,000. - A search that matches nothing shows a "No data found with given conditions" panel rather than an empty grid. ![Full table search](img/full-table-search.png)