dc/dc
7
1
Fork 0
Code Issues 21 Pull Requests 3 Actions Packages Projects Releases 89 Wiki Activity

fix: get metadata email if exists #143

Merged
allan merged 1 commits from fix-mpe_alerts-metadata-emails into main 2025-02-26 12:06:51 +00:00
Conversation 3 Commits 1 Files Changed 1
+2
henrik commented 2025-02-26 11:25:22 +00:00
Collaborator
Copy Link
Copy Source

Previous code had the part where we pick up the metadata email adress inside of the if-"fail". Moved it to the "success" instead. Have verified in our local install of DataController and it worked.

Previous code had the part where we pick up the metadata email adress inside of the if-"fail". Moved it to the "success" instead. Have verified in our local install of DataController and it worked.
henrik added 1 commit 2025-02-26 11:25:23 +00:00
fix: get metadata email if exists
Build / Build-and-ng-test (pull_request) Successful in 5m4s
Details
Build / Build-and-test-development (pull_request) Successful in 9m53s
Details
1bd0eef913
allan commented 2025-02-26 11:30:22 +00:00
Owner
Copy Link
Copy Source

Good catch!

Good catch!
henrik commented 2025-02-26 11:33:14 +00:00
Author
Collaborator
Copy Link
Copy Source

Good catch!
Should I click on Create merge commit? Or do you do it?

> Good catch! Should I click on Create merge commit? Or do you do it?
allan commented 2025-02-26 11:36:15 +00:00
Owner
Copy Link
Copy Source

just waiting for the action to complete, I can do it

just waiting for the action to complete, I can do it
allan merged commit 3a2361f42c into main 2025-02-26 12:06:51 +00:00
allan deleted branch fix-mpe_alerts-metadata-emails 2025-02-26 12:06:51 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
allan dcbot DylanLeong henrik mihajlo sabir sead trevor Yury
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dc/dc#143
Delete Branch "fix-mpe_alerts-metadata-emails"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?