• Joined on 2024-02-19
Yury commented on pull request dc/dc#115 2024-06-27 07:38:39 +00:00
feat(multi load): refactored range find function, unlocking excel with password is reusable

Please clean up

Yury commented on pull request dc/dc#115 2024-06-27 07:38:39 +00:00
feat(multi load): refactored range find function, unlocking excel with password is reusable

should be const

Yury commented on pull request dc/dc#115 2024-06-27 07:38:39 +00:00
feat(multi load): refactored range find function, unlocking excel with password is reusable

should be const

Yury commented on pull request dc/dc#115 2024-06-27 07:38:39 +00:00
feat(multi load): refactored range find function, unlocking excel with password is reusable

should be const

Yury commented on pull request dc/dc#115 2024-06-27 07:38:39 +00:00
feat(multi load): refactored range find function, unlocking excel with password is reusable

should be const

Yury commented on pull request dc/dc#115 2024-06-27 07:38:39 +00:00
feat(multi load): refactored range find function, unlocking excel with password is reusable

please clean up

Yury commented on pull request dc/dc#115 2024-06-27 07:38:39 +00:00
feat(multi load): refactored range find function, unlocking excel with password is reusable

should be a const

Yury commented on pull request dc/dc#115 2024-06-27 07:38:39 +00:00
feat(multi load): refactored range find function, unlocking excel with password is reusable

should be const

Yury commented on pull request dc/dc#115 2024-06-27 07:38:39 +00:00
feat(multi load): refactored range find function, unlocking excel with password is reusable

one-line comment would make more sense

Yury commented on pull request dc/dc#115 2024-06-27 07:38:39 +00:00
feat(multi load): refactored range find function, unlocking excel with password is reusable

it would be nice to define response type

Yury commented on pull request dc/dc#115 2024-06-27 07:38:39 +00:00
feat(multi load): refactored range find function, unlocking excel with password is reusable

It would be helpful to mention other possible statuses

Yury commented on pull request dc/dc#115 2024-06-27 07:38:39 +00:00
feat(multi load): refactored range find function, unlocking excel with password is reusable

variables for these string values would be nice

Yury commented on pull request dc/dc#115 2024-06-27 07:38:39 +00:00
feat(multi load): refactored range find function, unlocking excel with password is reusable

Please clean up

Yury commented on pull request dc/dc#115 2024-06-27 07:38:39 +00:00
feat(multi load): refactored range find function, unlocking excel with password is reusable

Please clean up

Yury commented on pull request dc/dc#115 2024-06-27 07:38:39 +00:00
feat(multi load): refactored range find function, unlocking excel with password is reusable

lint check should throw a warning

Yury commented on pull request dc/dc#115 2024-06-27 07:38:39 +00:00
feat(multi load): refactored range find function, unlocking excel with password is reusable

should be const

Yury commented on pull request dc/dc#115 2024-06-27 07:38:39 +00:00
feat(multi load): refactored range find function, unlocking excel with password is reusable

one-line comment would make more sense

Yury commented on pull request dc/dc#115 2024-06-27 07:38:39 +00:00
feat(multi load): refactored range find function, unlocking excel with password is reusable

should be const

Yury commented on pull request dc/dc#115 2024-06-27 07:38:39 +00:00
feat(multi load): refactored range find function, unlocking excel with password is reusable

should be const